Bug 17360

Created attachment 18585 [details]
Xorg.0.log.old

What happens if Option "AGPMode" isn't specified at all?

Specifying no value results in the errors and lockup.

I believe the user also tested AGPMode 1 and 4 (default), and only found 2 to work for this hardware.

Unfortunately, this is one of the problems with AGP.  Certain chip/bridge combinations only only work reliably at certain speeds.  Most AGP bridges are busted in one way or another.  We've been through this several times in the radeon driver (what to pick for default AGP mode).

Hi Alex,

Could we set up quirks for handling it?  

How does fglrx deal with this? Quirks?

Dunno how -fglrx handles it, but there are situations sort of akin to this in -intel that are handled by quirks, implemented in xf86-video-intel/src/i830_quirks.c.  There is a 'quirk_flag' added to the pI830 structure, and then quirks are applied on a per-PCIID basis in the i830_quirk_list[] structure.

This approach is nice from the distro standpoint because as we run across new hardware requiring that particular tweak, we can add support for that HW with one line of (non-executable) code - which is also easy to justify to folks for backporting as well.

Created attachment 18620 [details] [review]
Example quirk system adapted from -intel

Here's a rough sketch of what I'm thinking about (borrowed from the -intel source).  A few defines would also need added to radeon.h, and of course at the point where the AGPMode default is selected, it'd need to test for the quirk.  If this looks like something that might be acceptable, let me know and I can clean it up into a proper patch...  Or maybe there's a better approach I've missed?

Created attachment 18623 [details] [review]
Add quirk system for AGPMode

Here's a stab at adding a list 'o quirks to radeon_dri.c.

I decided to check against subsys as well as the chip and hostbridge since it sounds like these bugs are extraordinarily hardware specific.

The user can still override whatever we select as a default.  So if they want to fiddle with AGP Mode settings in BIOS or whatever, they can still force it to whatever they desire in xorg.conf.

Let me know what you think of this.

If we're going there, here's what I found in Debian bugs:
* http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=467460
  Mobility 9600 M10 RV350 needs AGPMode 1
* http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462590
  ATI Technologies Inc M18 JN [Radeon Mobility 9800] needs AGPMode 4
* http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=467235
  ATI Technologies Inc Radeon Mobility M6 LY needs AGPMode 1
* http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=461144
  R200 QM [Radeon 9100, 1002,514d] needs AGPMode 4

Here's what we'd add to the driver's quirks table:

    /* Intel 82852/82855 host bridge / Mobility 9600 M10 RV350 Needs AGPMode 1 (deb #467460) */
    { PCI_VENDOR_INTEL,0x3580,  PCI_VENDOR_ATI,0x4e50,  PCI_VENDOR_ACER,0x0061, 1 },

    /* Intel 82865G/PE/P DRAM Controller/Host-Hub / Radeon Mobility 9800 Needs AGPMode 4 (deb #462590) */
    { PCI_VENDOR_INTEL,0x2570,  PCI_VENDOR_ATI,0x4a4e,  PCI_VENDOR_DELL,0x5106, 4 },

    /* VIA VT8377 Host Bridge / R200 QM [Radeon 9100] Needs AGPMode 4 (deb #461144) */
    { 0x1106,0x3189,    PCI_VENDOR_ATI,0x514d,  0x174b,0x7149, 4 },

Debian #467235 didn't have lspci output or an Xorg.0.log attached, so I dunno what the host bridge is in that case.  

bugzilla-daemon@freedesktop.org wrote:
> --- Comment #11 from Bryce Harrington <bryce@bryceharrington.org>  2008-09-02 14:43:54 PST ---
>
> Debian #467235 didn't have lspci output or an Xorg.0.log attached, so I dunno
> what the host bridge is in that case.  
>   

Should be
http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=32;filename=Xorg.0.log;att=1;bug=467235

Brice

Created attachment 18681 [details] [review]
Update to include a couple more systems

committed: 937b7ac2a259cf504a19dcf62a58b1db1afb8eb9

Thanks!