Bug 17428

Summary:	Add Hold notification
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	gabble	Assignee:	Senko Rasic <senko.rasic>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	15907
Bug Blocks:

Description Simon McVittie 2008-09-04 07:16:54 UTC

With my implementation of Hold, we can put the other participant on hold, but we can't tell him we've done so, and neither can we see when he's put us on hold.

Prerequisite: update Jingle compatibility to XEP-0166 >= 0.25 (bug #15907).

Comment 1 Simon McVittie 2009-02-09 07:07:32 UTC

Setting as enhancement. It is.

Comment 2 Olivier Crête 2009-03-26 11:00:44 UTC

We should also react to the a received hold notification by calling "SetSending(false)".

Comment 3 Will Thompson 2009-03-30 07:05:49 UTC

(In reply to comment #2)
> We should also react to the a received hold notification by calling
> "SetSending(false)".
> 

I'd much rather make this a separate signal. Maybe there should be a RemoteHeldState/SetRemoteHeldState method/signal pair on StreamHandler, matching HoldState/SetHoldState?

Comment 4 Olivier Crête 2009-03-30 08:27:43 UTC

Why make it yet another signal?  It really is the same thing as far as the streaming implementation is concerned.

Comment 5 Will Thompson 2009-04-08 10:55:02 UTC

Implemented, including emitting SetSending() as Olivier said.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.