Bug 17551

Summary: Memory leak due to signals
Product: dbus Reporter: Marco Pesenti Gritti <mpgritti>
Component: pythonAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: John (J5) Palmieri <johnp>
Severity: normal    
Priority: medium CC: guillaume.desmottes, pbrobinson
Version: unspecified   
Hardware: Other   
OS: All   
i915 platform: i915 features:
Attachments: Cleanup self._signal_recipients_by_object_path

Description Marco Pesenti Gritti 2008-09-12 05:27:17 UTC
In Connection, add_signal_receiver adds object paths to self._signal_recipients_by_object_path and they are not cleaned by remove_signal_receiver.

As a result self._signal_recipients_by_object_path keeps growing indefinitely.
Comment 1 Marco Pesenti Gritti 2008-09-13 06:21:49 UTC
Created attachment 18857 [details] [review]
Cleanup self._signal_recipients_by_object_path

This seem to work for me. I know very little about dbus-python though, so I could very well be doing it wrong.
Comment 2 Marco Pesenti Gritti 2008-09-13 06:38:51 UTC
Simon, if you have time to take a look that would be really appreciated, even just to tell me that the patch is completely crack :)

This is a pretty bad issue for OLPC and we are trying to get a release out of the door in a week or so.
Comment 3 Simon McVittie 2008-09-15 04:21:44 UTC
Patch looks sensible. I don't have any time for dbus-python maintenance today, but apply it as a patch in the RPMs for now and I'll upstream it later in the week.

I'll follow up to this bug if on later review there turns out to be something wrong with this patch.
Comment 4 Peter 2008-11-23 14:19:57 UTC
What is the status of this, has it been committed upstream, is it in a release?
Comment 5 Simon McVittie 2010-02-18 07:11:13 UTC
It's committed upstream but hasn't been released. I'm gathering up low-hanging bugfixes now, for an imminent release.
Comment 6 Simon McVittie 2010-02-18 10:25:51 UTC
Fixed in 0.83.1

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.