Bug 17584

Summary:	Make Media channels requestable using CreateChannel
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	gabble	Assignee:	Will Thompson <will>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Simon McVittie 2008-09-15 04:46:38 UTC

As per bug #17246, CreateChannel should work with TargetHandleType = CONTACT, TargetHandle = a handle, ChannelType = StreamedMedia. It should create a channel with no streams (just like all the previous APIs did).

As a result, StreamedMedia channels should have handle-type = CONTACT in all cases, except when the channel is outgoing and was requested using RequestChannel(StreamedMedia, NONE, 0, anything).

Comment 1 Will Thompson 2008-09-22 11:28:02 UTC

<smcv> Robot101: wjt and I have agreed what he will implement, he's
       going to post it to the bug
<smcv> Robot101: summary: RequestChannel(CONTACT) -> they are in
       remote-pending and TargetHandle
<smcv> Robot101: RequestChannel(NONE) -> nobody is in remote-pending and
       TargetHandle is 0
<smcv> Robot101: CreateChannel (which requires a CONTACT TargetHandle) ->
       nobody is in remote-pending but TargetHandle is nonzero
<smcv> oh, and finally: incoming channels always have TargetHandleType =
       CONTACT, TargetHandle nonzero, and GetHandle returns nonzero (this
       is a change)

<smcv> Robot101: the remote-pending status of the oldest way to create 
       a channel is negotiable - we can either make it consistent with 
       CreateChannel, or with the past

The main advantage of making remote-pending after RequestChannel(CONTACT) consistent with the past is that the test suite should continue to pass without changes.  It's also not hard to implement.

Advantage of making it consistent with CreateChannel: fewer code paths.

Comment 2 Simon McVittie 2008-10-15 02:00:50 UTC

Fixed in 0.7.9 by wjt

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.