Bug 17588

Summary:	Reordering errors in spec will break ABI
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	critical
Priority:	high
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Will Thompson 2008-09-15 08:49:04 UTC

Currently, enum TpError is dependent on the order of <tp:error> tags in errors.xml in the spec; if someone reorders the error tags in the spec, telepathy-glib's ABI will break.

<smcv> tp-glib should hard-code an error -> number mapping, and the tp-glib build should fail if the XML spec contains errors that don't have a number until you add them to its list

Comment 1 Simon McVittie 2009-01-30 04:03:11 UTC

Fixed in http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/errors

Comment 2 Simon McVittie 2009-01-30 09:34:56 UTC

Fixed in git, will be in 0.7.25.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.