Bug 17684

Summary:	HAL fails to mount NTFS in user mode
Product:	hal	Reporter:	Ambroz Bizjak <ambro2>
Component:	hald	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	danny.kukawka
Version:	unspecified	Keywords:	patch, regression
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	fix fix by removing uid checks

Description Ambroz Bizjak 2008-09-20 18:23:03 UTC

Created attachment 19045 [details] [review]
fix

In HAL 0.5.11 and 0.5.10 (but not 0.5.9), mounting a device using the NTFS filesystem with KDE fails with an error "TODO: have to rethink extra options". It mounts however if I configure KDE not to mount the device in 'user' mode.

It seems the error is because HAL doesn't consider NTFS a filesystem that doesn't really store uids. I'm attaching a patch that solves the problem described by adding a check for ntfs as well.

I also added 'ntfs-3g' to the list because many distributions, when integrating the ntfs-3g driver with HAL, change the 'ntfs' fstype to 'ntfs-3g'. Example:
http://viewcvs.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/ntfs3g/files/10-ntfs3g.fdi?rev=1.1&view=markup

Comment 1 Bruno Laturner Lemes 2008-10-10 17:10:45 UTC

I confirm the bug is present and the patch that fixes it works.

Comment 2 Ambroz Bizjak 2008-10-28 11:07:41 UTC

Created attachment 19913 [details] [review]
fix by removing uid checks

This patch removes the hardcoded policy to only allow the "uid" option on some filesystems.
I say these checks make no sense, and it is very bad to hardcode such policies.
All required restrictions are already in the fdi as filesystem-specific available mount options, AFAIK.

Comment 3 Danny Kukawka 2008-12-12 22:48:00 UTC

Fixed in git.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.