Summary: | please add some news compose combinations to en_US.UTF8 Compose file | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | xorg | Reporter: | Frédéric Boiteux <fboiteux> | ||||||
Component: | Lib/Xlib (data) | Assignee: | Xorg Project Team <xorg-team> | ||||||
Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||
Severity: | normal | ||||||||
Priority: | medium | CC: | fboiteux | ||||||
Version: | unspecified | ||||||||
Hardware: | Other | ||||||||
OS: | All | ||||||||
Whiteboard: | |||||||||
i915 platform: | i915 features: | ||||||||
Attachments: |
|
Description
Frédéric Boiteux
2008-09-29 00:08:28 UTC
I have some concerns about using the U+FDDx characters as dead keys. We prefer actual dead_key symbols. There already is a dead_stroke, so: s/UFDD0/dead_stroke/g. In the pre-utf8 locales dead_cedilla did double duty as a dead_comma for those locales which have U+0218 thru U+012B (ȘșȚț) instead of U+015E, U+015F, U+0162 and U+0163 (ŞşŢţ). I’ll ask for some consensus about adding dead_comma and even dead_currency. Adding a dead_greek seems unlikely, however. With xkb you can have the greek layout available by using multiple layouts and the grp toggling options. A dead key for greek should not be needed. I will add the compose sequences which do not use UFDDx symbols, including the dead_stroke ones. And the dead_comma/dead_currency if there is consensus to add those symbold to keysymdef. About the UFDDx dead keys, I mentioned it as I thought it could be a problem. When we use these numbers to define new dead keys, we didn't know about dead_stroke existence. I found a file with keysyms.txt, but it is obviously out of date : could you tell me where to find the latest one, I'm lost in the whole X.org software ? So the UFFD0 should be replaced by 'dead_stroke', it's cleaner. About the 'dead_comma' (UFDD3), it don't give the same characters as the dead_cedilla (which is also present in the Bépo layout), so the former can't be replaced by the latter. It could be really nice if new dead_* symbols could be defined in place of these UFDD* hacks, and I prefer to wait for them and then submit new patches with Bépo layout and Compositions updated (as I missed the xkeyboard-config release deadline, it could wait for some days...). And for the dead_greek code, yes, you could achieve the same result with groups, but : - our keyboard layout has been defined with OS independance in mind (ever if I used only Unix-like OS, other people has a driver for Windows or Mac OS systems), and I'm not sure the group mechamisn could be realized in those other OS. - it is more consistent with the behaviour of the layout, which defines some dead keys to be able to add some foreign [for french] characters with a simple composition. If such a dead_greek keysym isn't added, could we include the Bépo Layout in Xorg with its existing UFDD2 code ? Fred. About dead stoke, as the keysym already exists, I should examine current Compositions for existing ones with this keysym, to be sure to remove any redondancies or conflicts in the patch of bug 17822. I've reviewed my libX11's patch about UFDD0 replaced to dead_stroke : I've found 21 redundancies between standard libX11 compositions and ones I'd like to add, so I should remove these 21 lines in my patch. I'd also like to replace UTF-8 codes (UXXXX) by definitions from latest keysymdef.h I've downloaded. So, before to submit an updated patch, I'd like to know if a dead_currency, dead_greek and dead_commabelow (more than dead_comma) will be created : I'll update both my xkeyboard-config and libX11 patches accordingly. If you have better names for these dead_keys, please use them. If the dead_greek can't be added, I'd like to keep the UFDDx code instead. Below comma keysym added to x11proto in commit d7147e09faaf1eded3a68c15ff3f76f8f60a272d. Created attachment 20224 [details] [review] update of the previous patch This is an update of the previous patch, taking account of dead_stroke and dead_belowcomma defined in x11proto. As the dead_greek key hasn't been accepted (and thus not put in Xorg's Bépo layout) and that all other key combinations have been added, this bug can be closed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.