Bug 17926

Summary:	RADEON_MSI_REARM_EN is defined twice in radeon_drv.h
Product:	DRI	Reporter:	Coleman Kane <ckane>
Component:	DRM/other	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	medium
Version:	XOrg git
Hardware:	All
OS:	FreeBSD
Whiteboard:
i915 platform:		i915 features:

Description Coleman Kane 2008-10-06 07:26:18 UTC

In the recent commit to the radeon drivers:
  * "radeon: fix bus master enabled bits on newer asics"

Adds two #defines of RADEON_MSI_REARM_EN to the radeon_drv.h file. This causes a build failure, though I cannot find any place in the code where these defines are actually used.

I have simply commented out the lines. They are at lines 447 and 449 in the radeon_drv.h header.

Comment 1 Robert Noland 2008-10-06 08:30:39 UTC

(In reply to comment #0)
> In the recent commit to the radeon drivers:
>   * "radeon: fix bus master enabled bits on newer asics"
> 
> Adds two #defines of RADEON_MSI_REARM_EN to the radeon_drv.h file. This causes
> a build failure, though I cannot find any place in the code where these defines
> are actually used.

I'm getting ready to try and use them. ;)  I'll fix this up today, unless someone beats me to it.

robert.

> I have simply commented out the lines. They are at lines 447 and 449 in the
> radeon_drv.h header.
>

Comment 2 Alex Deucher 2008-10-06 09:15:20 UTC

Fixed:
6f9dfa098fed73895f4ad32f9274ffaa163d3efb
That's what I get for committing code at 3 AM.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.