Bug 17953

Summary:

xf86Modes.c xf86PrintModeline(): Also print DisplayMode type bits.

Product:

xorg

Reporter:

vdb128 <vdb128>

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

enhancement

Priority:

medium

Keywords:

patch

Version:

git

Hardware:

All

OS:

All

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

Bug Blocks:

17954

Attachments:

Description	Flags
xf86PrintModeline(): print DisplayModeRec type bits	none
xf86PrintModeline(): print DisplayMode type bits.	none
This patch applies to git 22 Nov 2010.	none
Added the letter bitmap description as a comment block.	none
Xorg.log using the patched xf86PrintModeline(), X from git 20 Jan 2011.	none
print DisplayMode type bits.	none

Description vdb128 2008-10-07 12:44:44 UTC

Created attachment 19454 [details] [review]
xf86PrintModeline(): print DisplayModeRec type bits

The patch below adds printing of the DisplayMode type bits.  
It helps to trace the modeline origin and to understand the 
initial configured modeline.

type_bit       flag   origin
M_T_USERPREF   U      set by the Option "PreferredMode"
M_T_DRIVER     e      driver: EDID, flat panel native, GTF fallback
M_T_USERDEF    u      zoom modes Ctrl+Alt+Keypad-{Plus,Minus}
M_T_DEFAULT    d      VESA default
M_T_PREFERRED  P      driver preferred timing, also set by PreferredMode
M_T_BUILTIN    b      hardware fixed CRTC mode

Comment 1 Corbin Simpson 2010-03-19 22:00:38 UTC

Patch no longer applies and the target code has been changed drastically. If this is still desired, could you respin the patch?

Comment 2 vdb128 2010-09-06 06:08:09 UTC

Created attachment 38474 [details] [review]
xf86PrintModeline(): print DisplayMode type bits.

This patch applies to X Server 1.9.0.

Comment 3 vdb128 2010-11-22 00:32:23 UTC

Created attachment 40470 [details] [review]
This patch applies to git 22 Nov 2010.

Comment 4 Matt Turner 2010-12-03 12:39:39 UTC

Please send this patch to xorg-devel@lists.x.org for a review. It's not going to be applied without a review.

Comment 5 vdb128 2010-12-20 05:36:36 UTC

Created attachment 41291 [details] [review]
Added the letter bitmap description as a comment block.

Comment 6 vdb128 2011-01-22 15:04:16 UTC

Created attachment 42321 [details]
Xorg.log using the patched xf86PrintModeline(), X from git 20 Jan 2011.

Comment 7 vdb128 2011-08-30 21:32:24 UTC

Created attachment 50741 [details] [review]
print DisplayMode type bits.

This patch adds printing of the DisplayMode type bits to 
xf86PrintModeline().  It helps to trace the modeline origin and to 
understand the initial configured modeline.

> This is rather useful if you're trying to figure out where a mode
> might have come from.

A letter bitmap description is in the code as a comment block.

Comment 8 vdb128 2011-09-22 07:14:45 UTC

Merged.
   c92c835..2f47433  master -> master

-- 
keith.packard@intel.com

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.