Bug 18338

Summary: check_os_sse_support can leak exception under win32
Product: Mesa Reporter: Kamil Hornicek <tykef>
Component: Mesa coreAssignee: Brian Paul <brianp>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: x86 (IA32)   
OS: Windows (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: partial fix

Description Kamil Hornicek 2008-11-01 08:58:27 UTC 
If application using Mesa has it's own exception handler it can receive exception STATUS_FLOAT_MULTIPLE_TRAPS from check_os_sse_support. This affects apps like Unreal Tournament 2003/2004 under win32 when using Mesa compiled with USE_X86_ASM, USE_SSE_ASM. I suggest using AddVectoredExceptionHandler / RemoveVectoredExceptionHandler instead of SetUnhandledExceptionFilter to solve this problem.
Comment 1 Brian Paul 2008-11-01 15:45:10 UTC 
Could you provide a patch for that?
Comment 2 Kamil Hornicek 2008-11-02 13:19:28 UTC 
Created attachment 20013 [details] [review]
partial fix

I was thinking about something like this. But it will only work on WinXP and newer. I'd say you can never really know that your exception handler will be called so the best way would be not raising that STATUS_FLOAT_MULTIPLE_TRAPS exception at all...
Comment 3 Timothy Arceri 2018-03-07 04:31:13 UTC 
Hi Brain,

Looks like this patch was never applied. Are you guys interested in it? Or should we close the bug?
Comment 4 Brian Paul 2018-03-07 15:32:22 UTC 
The file in question, common_x86.c, is only compiled for non-gallium Mesa builds and, thus, is not built on Windows (we dropped the non-gallium Win32/GDI driver years ago).

So the original issue and this patch aren't relevant anymore.

Closing this bug as won't fix.

Thanks for cleaning up these old bugs, Timothy!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.