| Summary: | xf86pciInfo.c uses it's own broken MIN() macro | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Kristian Høgsberg <krh> | ||||
| Component: | Server/General | Assignee: | Xorg Project Team <xorg-team> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | trivial | ||||||
| Priority: | high | CC: | roland.mainz | ||||
| Version: | unspecified | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
|
Description
Kristian Høgsberg
2004-11-11 14:02:37 UTC
Created attachment 1293 [details] [review] [FIXED_X11R68x] min macro patch Patch to make code use standard min() macro. Comment on attachment 1293 [details] [review] [FIXED_X11R68x] min macro patch Erm... are you sure this works on all platforms ? AFAIK the |min()| thing may be a library function which isn't available on all platforms. (In reply to comment #2) > (From update of attachment 1293 [details] [review] [edit]) > Erm... are you sure this works on all platforms ? AFAIK the |min()| thing may > be a library function which isn't available on all platforms. As I said in the comment #0, the min() macro is defined in Xserver/include/misc.h, so it's independent of you platform. Comment on attachment 1293 [details] [review] [FIXED_X11R68x] min macro patch Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone call. Please don't commit it yourself, I'll handle that once the CVS service is available again. Comment on attachment 1293 [details] [review] [FIXED_X11R68x] min macro patch Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.10; previous revision: 1.365.2.9 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/hw/xfree86/common/xf86pciBus.c,v <-- xf86pciBus.c new revision: 1.4.2.1; previous revision: 1.4 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... The patch seems to be commited to Xorg trunk and has now been commited to X11R6.8.x stable branch, too - marking bug as FIXED (please reopen if there are any issues left). |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.