Summary: | [Cirrus] extend cirrus driver to NEC PC-9821 and modfication of documemt | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | xorg | Reporter: | Satoshi KImura <satosi.kimura> | ||||||||||
Component: | Driver/cirrus | Assignee: | Jeremy Huddleston Sequoia <jeremyhu> | ||||||||||
Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||||||
Severity: | minor | ||||||||||||
Priority: | low | CC: | ajax, jeremyhu | ||||||||||
Version: | 7.5 (2009.10) | Keywords: | patch | ||||||||||
Hardware: | x86 (IA32) | ||||||||||||
OS: | FreeBSD | ||||||||||||
Whiteboard: | 2011BRB_Reviewed | ||||||||||||
i915 platform: | i915 features: | ||||||||||||
Attachments: |
|
Description
Satoshi KImura
2004-11-11 23:27:50 UTC
Following patch file for Xorg 6.8.2 is available to make use of cirrus driver on NEC PC-9821 with CLGD755x. begin 644 patch.clgd.gz M'XL("!@3G$,``W!A=&-H+F-L9V0`W5AM<]I&$/XL?L7&F>E`$$8"219XD@D! M;-."<0$GZ:09YBQ.H(F0J"0P;NK_WKT[B5?)<=+V2S4>R[K;?6[WV9>[<ZE4 M@K557@3^-"#SL/PQI,&*!N79?7EM!Y2:1GD2.#@2EBTG");\-19#I]:I'SA3 M:4@B^'GI0E4%1:]7E;I>@8JB:+EBL?@/P*71;`D]\@`J@ZOK9EU1&:Z>>_L6 M2J8A&U#$WR:\?9L#Z2O<-#OCYE7G9GS9TC5#>]>2I9-FMY1\G<"CG"*GR])6 M3$\3.M,U4X:]1RBP":Y0/%30]0P%7<]0,+(4C,2DDHJ6XG-]V^W"8PX>SW/` MF5"5*J-"5?2GN$AA9]`>CH=7C4&[-7Y_V<BDYVC@FWJ<,>EHX%@OC3CI:.`Y M>L:AGI%E9\QC0B<3NKUNM2\ZU^U60FOINZN"N(N4JF@L`JAHH&CUBEFOJ#]: M%;O@3U>%JM1$+M1DG&?)$$8D<BQ8^<Y$:KB+EA,N7/)PX]_3H$<\,J5SZD5# M&N6'5N!U/-N_B0)8L`]&U_9QO`@.M'K^A,K`)FR73,,"8ZY8?@5@^P&&IV8" MO"KGBB\GU'8\"GQH//P%(]2Y'JE*KI@K[EC'IYN=P>!VB.%;MSURY])CJW"5 M)[30O6RU')1?Y=`F&,V<$-B/%Z$;CN\1UWV`T$+RO9+C3>B"XB\O.@7H1"@U M<2P2T1"B&84[]NE-.8XU\QV+PIQ,*$KQ:=L)0B0JH!W/B4Y%3#11GUHMKL_8 M?$;<=*)KFC'ND773]:TOX:?/\!J^@EK55461-V\P=7WOS1Z%Y^H!F*ED@F&2 M*+OO_46.P5C1'H&!J<06/?5F8,4#,%W_-\&..7L^&&P2H>M@L'P;PH?YG>^& M8`?^''R,8P!S?[)T><RQCB.6,&($`FK3@'H6#3$]6";Q(&LZ#[)FJ+*JBBXL M27<!)5]P/0G[2O*!2<^"9Y&0'K:^>N:4@5/2RIE0'SL&>EM1-/,<1;?%5JJ9 MV%^Z1*T"C:Q347D;`]CSR/P&H71[W2,+GJ_8$F!.YW[P`,2;0*_7Z0-!K9`! M,,=TXXPYIIN*7$O\$L^BZ02E-S>6PPJM]&9"5U@,<K:`O?0LT2->.C;VA.-^ MP*QS;,B_6-NFT0EOK)J9+Q3@*VI@03JVL)]),(&N3R;#Y5V/AR4O6A:<8(:H MR@G7`BD1H\&`_C%\F+-XAWDN,A0AE]EVRJSBLJU@U0NG`JOT)N1-9$+7\D>T M\*(O([@3.<1U_L0.`!SF=^\$M3E1R!`CJF8D1"TLYT/@1+3K>XB9D#$B4UE9 MJYI\0`]&X1U&_I/ZF9N3!.U)LAZWS&QBB[T<8@?F/MJ+Z8&A1&OVQUXG0I;O MV4/1^I))X9`A4MHXJ\BJP3U"%%XAK^'C&'?,QFUWQ$P5CEQ]:"Z#D"-?-+K# M-D]U*;QW(FL&L?O-F;,(:<1#*F640-HXSW^`HX5&@UNV#DXEU24A5V3I1O7] MT4?6_:4D<RYIU%]$[XG[SO?=V#0<P(T@E*%_,^KTK\=7'\;-V\&P/Y#AI_UU M"P66XQLBFOWKB\YE<ABK5?D&7#/,9`.64AS2S#J;2`Y["P0Z[+=QU:8]&Z\R M*3Q"WFV^YR)WOAO92$<VO@<9G6:]D$?BQ8(3*04T6@9>DC1BQZSH8LLTDJZ# MDJLIN?IP$_@1M:*DW+F2:"J;Z&X:!S,W]5"Q<R)(5A>9Q)LDM\",-VW35+<6 M8+,<T!`+9`L1F]5%]_.S^T5!9/TS3$E.*AL@WI_CQ44K46N5G<7C<EWA86U. MMD7V3,\/ERO&B+SL,7HA%1^L+XA2W8Z=;VG*OTI3*N2WK1)B`>$2<Z>"X92K M4*RH>%O3DZ)@.>&O3Q\J4$HZT<H)HB5Q?RML=ZS'@T-BKOC,4Z+8&_$,1X,Q M<5"D(+;$KSQ%EU[H3#TZX><)=L!#PR<D(B*!1:(A%`84^<"[`WZ.!CO<,2E_ M&=WEE;5-+!F4M5(YG,`.P,9IX7QOE/#1L[11TTZ5-7:1[_-HSGC8_A6W@5;[ M(Q-0*TQD4VG,[Z7'ZA'$]0'"!;5PUQ($<"#N,;J&#I;>=/ILWX$B<W3<'(R: M`GK<O[@8MD?"(D8.9"NT&J/&GCSW0/"*%E:M7<<8ELQL$'\6X"<4H7N^;S15 M\DU-N\I$OI4HV1<#P9A+R8K^=YGR_PF;LCY3?R14?[%4MM*J!\>5C.))+XCT MXDDMM(J:-FK4L@N-)=(SKO^6/\?#4IEUW?@$=SH[_F_861VOZ-]Q[T]#??K" M7\7>BEL%>YWQSHIYU!3YT_6G6`SL[)?<P`_.(+CW,NZK9H:$KL<2FK*]Q1^< C"1*)9BJ&KE656**A9$EH8RT6T;)%S%C$S/T-=:L@;[(4```` ` end Following patch file are documents of cirrus driver on NEC PC-9821 with CLGD755x. This file includes kanji (i.e 2byte) codes. Please be care to handle this file. begin 644 patch.doc.gz M'XL("!P3G$,``W!A=&-H+F1O8P"]6OM/&U<6_CG\%4=6?X#U:V;\P$:J-M20 MA%5X"&B6WU83>X#9&@\[-@FL^L^8W*FJA"AI$@J$0-(\@/!,U*W:2&G317V% M)&TWT>ZVJVVUY]P[8\\8`P;2M1*/?1_?/?<[W[WWG&N"P2",IL/#IC%@JD/Y M<%]>,\]H9GCP;'BTW]2T1#S<=RR92!FY_E!Z>#ADF/K`D1ZU`,W#)BA1D*)- MBM0D*:!(4K3.[_?O!^U(ST@.6K0TR#(02K(I%B.@6-W1HQ"4`S'PRX$H'#U: M%^Q+=;:WPQM]QSA*TWY&"9P!.10A7#DL*V&YD<:**4T1"3+J62T/K:/#\$9Y MB(Q1Z#0']C^$X"",_Y0(R$F;%TU/#]HC^/<YPJAA#B03M>,#Q[<?D#*&Q]!9 M@P6H3S=@^V0TB&\).#T&O8,:V$Q"EVG\64L7`M"62X<<"*)?B0<:P:_$\!T= M8(-F-#6KYP;RH.>@,*CGH<?H+YQ530W.ZH5!8Z0`PZ9NF'#6U`L%+0?J"):: M^E_5@F[DH-\TAK";YJ!5V%`:ON0*Y#=OF`5]9*@)&R?B#M\0'E+U7%A1:%[Q ML"QQ2N2F:*0I)L,[:E8[[>;;"U-V6VTPX)C[N]?R<M!ZB3[\IT)>'1K.:I!& MJ_2!$=/F2L<B(Y<="R#72&5&RT#!`#V;'<D7L(TFUHB4("_)4F,@[G(3Q\X: M:B9/=$/OV+`F!Z!G6-,R!JBY#!#Q5`K]1JX`0T9F)*OE::;T.HD=C_@*U,E7 M%RR7Y'E_G[L1*94:^JAO:R[3@VY$Z[EMT;B"1OFC<2F@2-PX3Q.H\]L?P==N MY/2"8?KJ_(C<EM%R!;U?UTP`7S/1T'NL%TZF6D3U*>3",#O4(0VK.UI3HK3= MR&A940B^DZH<$<4G2'P]8[DTF1R)A*1@0@E)`#:26>C6<`KY08!8#"N34DBJ M\SO"Z3_Q9C0>2@;Z3[W9&*,*>YR3>DX#7T*21N.2Y(-H,A23`+]"(A('2.)D M92D6!ZS$_S+@6Q3?E)@'.18)-1)R(A:2JR.?\$$L'HIL@XXF*J$CB.!BUO_; M"/:XJ0X/ZND\;@)G]+0&><>1KW4PKIQ$DI03D^2`[)8UOCJ':<PCOCY5[3!Z MTBB_7*_]3!E9P\2=$/5]#)>)S]7KE)[1C&YUZ(B"['$5YDM<E578PN>U382^ MU,GC+8VQ6&R;_GPIW31'\K@6!O2TJ'W+4,V,+4[J!^6.+:9^AC1-"DWSCCY' M#_:T1%W^+*1'3-RP?.`S<N4V;XWDVUI`M.E*M35)39$FJ5SMS!&K^2S]GK7V MFRA"\.X((1^J"^X=362,=)B;RIG"XZU:1"$W11IKCB@J$8_T#HY`NSH&LL)/ M^D23)+NBBE@\D,0=DS](6N]VI9()1>XXW1A.!6Q^^>M=X?=HQ/D.;X7;^-/Y M(.-'Z.-%[[J`9`D\+P<HL4^@T7`DD&KT`(V=ULQD1)%J`@HZ0"8R4<TBC+9V M`E)V`(J$6]S3.QQ0--`C1[U`\=J`_(><FO%[^M3I`3K0U'8"VO?42D!0!HJ! MY^6X/Q&KB2,WD/3:@,(]BE0%*"C7`,377SP90)_Y[:=K!9XL5+AROWHO`:F- MKPMH^U(^T`JD@*02:%\+QW]8(`-L=?F#.[PJ*_R5Y7Y7D;\\M?QKVEP0Z'`< M[0U4X^;B`MJV<`[FM0-RM&US.2A'^P"J<9?R'Y*C\G;WN@2)>!CGU!B!_$'% M,%'+:^'NUN:6]E9W&-)A8+(=`PG3P$13+$J10Z36,&0;;,4-1TRFQ-)UPZ'( M=,6!62?=<4`Y(49NL=LPI7V8G[7E^@US2!4!:ZE5N*_3'-BM*3)2)=/GB3Y/ M`ONP9ZJSNQ5Z6YO;X<Y/9`':)L'B)8C#U/?X!1;^2R.2Q52*,L9BF@R6`[5G M5]FZ==^Z:'UM_=UZ92VQ1;91'.=&32^N763KL_^:^9*ML+N,L84K+V]MLBGV M!9LIGNM*A9M[8?K)M9G)(@=:^O"]NZO>]@0E2CU#O)R],K^$.`M7;K!)QHKG MR,3JACAS9^?9=^QCZ#.0,>R_M/:0S;!GUS]GZ^"RE7!JL7=W6PEE#WMYHBV' M`%8>6UO65O&&->/@"%I=Y65"UQ[BSF)-8ND#M@%N@]PU2_=^F?D6ZJU/+,ZK MQ:QGJ_--C@H:`$UXCN:>9UO%\;GYM>^0ML?8\3Z$P?K(NF-]:LWB^](*50C$ M3;;,/72)+;,M9&.*W2R>P^?-XOC5!9SI4QP#+4)&'[$%Z#EUO!FL1\)V\D`B M_J>>B%.RSFTJ]QGGB+/L5?'<]-SU)VR=+:$G7]@S9HL+EZ]_3]0A-<^P$JD8 M&E"+XX2B#@\5QP>R>JY0'"^8.I=_"7F=/4'FT&_MF`IJN9P^@HW;Q_(%_2\C MFNA_RC`RAM']=L\)'$TSA[2,KBK%\=[C;[<EXXG1>ASR.E*UB4RW(6TV3>PE M.S_["_N(K2__<GGYZF7.#)H5"3ESA'IM-`3X/41LKU^[^^%%]G+ZF[6?UAXZ M`IB>F_\G1$,2D'>A]7@*V%<$U,4_SK"GU!CK+CK<7+VP=(FKZ0&;6'HU_P-; MF2=OT/\[)7*0;6K'+5KY<&[U')M`-Q/#:"N.P]>[86K0JV&:B-#88?J;C?&U M%^Z%=!CQ@=`=:8Z@5N=I5&<)HF#H*RY!I(6KM$8I$I17C@>3HM@[O7*L+D7! MPWX$646,Q7&1Y2-8K;+<0Y)D5HVRW%62A%.K+'?6)*'L1Y?5-,E=LK<L^7[I M7`#KN(5_-7EIX?+LKSC[\ZB2*>M;Z]6]GQ'RX<R,>T/N;CW9T=G;VH/K8?XQ M>NW2W#\(B5<+=\\(^RIWZ/!(W@SWR7)W/)S53].G<'GX4#(A;LB3=+'IC_!C M7-QOXE$9HGW=FK0^1^*7K`ODG,O/U_XM]G6L>81LW2K>$,&1J%^=GU^'FEYB M"0@D3W#D_;;WRVDOH#I:4^Y!/K&>61>LISC4>]8Y-/<^/L>M2[@:GUK/L?2F MO4S[1%1KKW`!U:X63&/4@6K'!5B6>KUWVVC8/C\/5%MGL*6YM]FN.MX<I(41 M#Z/N:Z'*:Y6631NEJC^>Z`IV]20"]H?HOJ#J/6:A55UM;0@E/IQ([(93AFH0 M.\Q.8A"U!W:PZ'Y@IXKN^W&DZ+&SOVS$79T@VNS!;H.SR!37(EO8O#UN?6PM MXEXP9<U8"]:7NRPXU[FRE]MY^__'@O.2&W;.@[U$5`VJUPZ$2E%,7Q`=J05. MJ=D1K:>@FG#OYX8J4-7D6'$$'YR`:GK<8<[5FM8TIVH=W=?S8*>EHU#/?U.B M+EQ+$502!>X4S&,)S\N4>$".8F:&.[R<*&WMT9`K="V'ZSCPY64\.-9YNK"" MQQL_?<J!SP4[[[C`5C[XE4UC8%(^2_B/O"'ZZ8\G,7::XB1XU&U(S<&P.J!A MWK)PGSU9GF`?5&0^R^P\>$XG#$AY*L(CC3J_L)V.)0Q52C,0<R+"V#I?09[- M`.KM]5_%1PV!BOB/@,KMG"`)$ZP26\(2OB+)$K+%?9ROWWIR=XOFLKVR3)#3 MC*.(!#M$*EI`TCGU(IK$F*,<%&#N]=G=+3MJ01/NKF*,LK%P!WO<9)LT(E'B M4,P6#XB#\^?U..7[$VN?KJ)OEMXK3=JFG[:LY5<S/Y;Q5[^ZO67_*(%"B]"E M:)R>9<')(1+=M<\VQBNG[616%.(Z]GLN!]S:"7BFZ8"301BW5BC"V8`Q-?8< MN7MY5=G-JY65U;P*I>F148?PZF[>X&PGQ(_F2>=O&QPZO%SO@U\'@O82G@2X M.>5#)L5?4T@1>TB>F-L,>AFG`X_B[E)`@8'M(MMTR,==A.XDGE,4SF/95V47 M1'9S067E[BZ(M&35T_D#>X%;MKFK%Q0YRC=919'I6?9#Y.!^"-CL5_J%`"NO M"/;:_RI.'2F,;TI#U67`9XOS:DZGM2PE3^=GEQAS92]!8<0NWJFLW,$[X/J= MEW[EK;>S:EE2H@UUI8.OU(9-W)JDO&>Z./>`>VJ9L?GGF'FO$*;G3DK\S4], M^*11"42EDD\P:'NG@.DHIE'WYVZ\S\7P;'EZ]C\\?\;P@$U@VC>U]CWFGU_8 M>X*?=ZL@4:%##+FFO!T#JQ^@OEM5)$I)*9L%ZP'=@U6$!N)@MX-C]O(CGO33 M'(KC]^Y-ST)GAW.U8&JG#:,`5#_]-5OD>UY&_.C.7MHP"EQY1;DC7TI+T(FI MX36V9&U@X"/*KF*^/^'9IL6,1'='1`XLYLET\4@;.=NX-8V'>RDY=I1'>P*; M8^NWYTMD8J-;<W-XDB]CL#I#],W\C?U@#X<>HIR45&8]%P$N)??7MK!\JD2O M#5[U='",9!O3<[._WKL%]9C3-XBDGM\!`";RJ/FU!2P:I\L7G,-SMC)Y\?IC M-LFOC^S%[OQ=`EI_$Y/Z#7YQ:LN(C+SSXO(GE1>Q.RQ,QZCR&A;"C^$,Q#U) M>67RJIU79M6PKOK*M`,@>Z2]EIC?N2$J1U*T`4Y>Y%JXN?/61_V\A]".6U_) MF!W"`;]8.=8+U",NA?:V3B<J;%.0D!7R-BG<>I]R.:CWU;>V-OAP\LZZ1"(F MA%IQR=,%QX3MWXT;MZ]_CO'IQM2CF1]16H^L9S9E6';MLZEI[M7OV#9+70JV GK3N\@DO@)07[=Q&/+1#OMD[*N;I`2Y@N!TF*=@C_/X]7M;+4*@`` ` end When submitting patches, please use the "Create a New Attachment" link in bugzilla to attach files directly (not gzip'ped and not uuencoded). Created attachment 4071 [details] [review] patch for CLGD on PC9821 Created attachment 4072 [details] [review] modification of documents I see. Please check Attachment #4071 [details], and #4072.
Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future. Created attachment 52428 [details] [review] patch for CLGD, X.Org 7.5 new patch of 4071 for CLGD and X.Org 7.5. Created attachment 52429 [details] [review] patch for server, X.Org 7.5 new patch of 4071 for X server (xorg-server-1.7.7), X.Org 7.5. 1. Add to comment 7, 52428 is the patch for xf86-video-cirrus-1.3.2. 2. patch of 4072 for documents were obsolete, since japanese documents does not exist for X.Org 7. 3. change QA contact from original to new default (xorg-team@lists.x.org). Is this modification correct for the request of comment 6 by Daniel Stone ? Thanks Satoshi, A few notes: 1) Can you add this appropriately in the driver: #ifndef PCI_CHIP_GD7556 #define PCI_CHIP_GD7556 0x004C #endif which will allow the driver to build on older servers which don't provide that macro. 2) Does this chip have a similar issue with a maximum pitch as reported in this bug report for other CL chips? https://bugs.freedesktop.org/attachment.cgi?id=52605 Whoops, here's the correct link: https://bugs.freedesktop.org/show_bug.cgi?id=23775 Dear Jeremy, > 1) Can you add this appropriately in the driver: Yes. Please add your modification to alp_driver.c and cir_driver.c. /* Drivers for PCI hardware need this */ #include "xf86PciInfo.h" +#ifndef PCI_CHIP_GD7556 /* for old xf86PciInfo.h */ +#define PCI_CHIP_GD7556 0x004C +#endif + > 2) Does this chip have a similar issue ... (1) on https://bugs.freedesktop.org/show_bug.cgi?id=23775 > GD 5446 uses 9 bits to store the pitch value Since I have no Reference Manual, I cannot know the length, i.e number of bit of pitch value on GD7555 and GD7776. (2) Specifications of my PC is as follows: Chip : GD7555 VRAM : 2MB TFT : 800x600 (fixed because of Note PC) I set depth 16, so bits_per_pixel is 16. So, the value of accelWidths[i] * pScrn->bitsPerPixel / 8 are as follows: 800*16/8 = 1600 < 4088 2048*16/8 = 4096 > 4088 <- over, but 2048 may be too wide for VRAM 2MB. 2048* 8/8 = 2048 < 4088 <- if set depth = bits_per_pixel = 8 So, I cannot reproduce this issue on my PC. Dear Jeremy, > 1) Can you add this appropriately in the driver: Yes. Please add your modification to alp_driver.c and cir_driver.c. /* Drivers for PCI hardware need this */ #include "xf86PciInfo.h" +#ifndef PCI_CHIP_GD7556 /* for old xf86PciInfo.h */ +#define PCI_CHIP_GD7556 0x004C +#endif + > 2) Does this chip have a similar issue ... (1) on https://bugs.freedesktop.org/show_bug.cgi?id=23775 > GD 5446 uses 9 bits to store the pitch value Since I have no Reference Manual, I cannot know the length, i.e number of bit of pitch value on GD7555 and GD7776. (2) Specifications of my PC is as follows: Chip : GD7555 VRAM : 2MB TFT : 800x600 (fixed because of Note PC) I set depth 16, so bits_per_pixel is 16. So, the value of accelWidths[i] * pScrn->bitsPerPixel / 8 are as follows: 800*16/8 = 1600 < 4088 2048*16/8 = 4096 > 4088 <- over, but 2048 may be too wide for VRAM 2MB. 2048* 8/8 = 2048 < 4088 <- if set depth = bits_per_pixel = 8 So, I cannot reproduce this issue on my PC. I cannot remove comments. If possible, please remove comment 13 and this. commit 28aef0c4a45288751b2d5b7d5d0c452a116a5b38 Author: Satoshi KImura <satosi.kimura@nifty.ne.jp> Date: Fri Oct 21 15:34:41 2011 -0700 Add support for the NEC PC-9821 https://bugs.freedesktop.org/show_bug.cgi?id=1837 Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com> Also, *PLEASE* test the current (master) cirrus driver with the current (master) xserver. We just pushed a bunch of changes to the BUS support, and I don't actually have a card to test this driver on, so if you could verify that I didn't actually break anything in the process, I'd appreciate it. Thanks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.