Bug 18566

Summary:

towards xorg-macros-1.2

Product:

xorg

Reporter:

Peter Breitenlohner <peb>

Component:

* Other

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

CC:

alan.coopersmith, jcristau, pcpa

Version:

git

Keywords:

patch

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
patch 1/5 reorganize	none
patch 2/5 CHANGELOG	none
patch 3/5 CWARNFLAGS	none
patch 4/5 cygwin fix for RAWCPP	none
patch 5/5 bump to 1.2.0	none

Description Peter Breitenlohner 2008-11-17 00:34:31 UTC

There was a discussion on the xorg mailing list that a set of CWARNFLAGS
should best be provided by xorg-macros as a central point to define them in a uniform way. Further flags for compilers other than gcc can be added there as appropriate.

Likewise a replacement for the rule to build ChangeLog (broken for git-1.6.x) should be included.

Using suggestions by various people, I'd like to suggest the attached five patches for util-macros:

1. Reorganize the autoconf macro files, avoiding the need to copy some code
from xorgversion.m4 to configure.ac

2. Define the XORG_CHANGELOG amcro and use it for xorg-macros

3. Define XORG_CWARNFLAGS macro

4. Fix XORG_PROG_RAWCPP for cygwin (patch from the xorg mailing list)

and finally 5. Bump to 1.2.0

Comment 1 Peter Breitenlohner 2008-11-17 00:36:15 UTC

Created attachment 20359 [details] [review]
patch 1/5 reorganize

Comment 2 Peter Breitenlohner 2008-11-17 00:36:55 UTC

Created attachment 20360 [details] [review]
patch 2/5 CHANGELOG

Comment 3 Peter Breitenlohner 2008-11-17 00:37:35 UTC

Created attachment 20361 [details] [review]
patch 3/5 CWARNFLAGS

Comment 4 Peter Breitenlohner 2008-11-17 00:38:18 UTC

Created attachment 20362 [details] [review]
patch 4/5 cygwin fix for RAWCPP

Comment 5 Peter Breitenlohner 2008-11-17 00:39:04 UTC

Created attachment 20363 [details] [review]
patch 5/5 bump to 1.2.0

Comment 6 James Cloos 2008-11-17 17:04:31 UTC

I’d also grab the dolt macro (including the patch added to cairo for
compatability with older versions of bash).

Comment 7 Paulo César Pereira de Andrade 2008-11-28 23:39:23 UTC

  Thanks for the patches.

  I was only unsure about adding the version
bump patch or someone may bump it again prior
to a new util-macros release :-)

  James, you mean
http://cgit.freedesktop.org/cairo/commit/?id=1d8ad69abb88f6e0283b6ce2aadc5d801b8e3722
?
  I think it should be applied to xserver/acinclude.m4

Comment 8 Paulo César Pereira de Andrade 2008-11-29 21:34:38 UTC

Marking as closed as there is now a
util-macros 1.2.0 with the patches
applied.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.