Bug 18616

Summary: Screeching sound at end of videos
Product: swfdec Reporter: Mackenzie Morgan <macoafi>
Component: libraryAssignee: swfdec ml <swfdec>
Status: NEW --- QA Contact: swfdec ml <swfdec>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Mackenzie Morgan 2008-11-18 18:35:58 UTC
At the end of, I think all, YouTube videos, a loud screeching, crackling noise comes out of the speakers.  An ALSA dev suggested it had something to do with it not releasing the device properly.

I'm using swfdec 0.8.2 on 64-bit Ubuntu 8.04 with libasound2 version 1.0.15 and pulseaudio version 0.9.10.
Comment 1 Riccardo Magliocchetti 2008-11-18 22:31:51 UTC
From the other stack trace i see you are using pulse audio backend. Can you try this patch?

http://cgit.freedesktop.org/swfdec/swfdec/diff/?id=374d3fa055499b9a59dcd1f561a0523bc3fe8142

You can apply it by patch -p1 < foo.diff from swfdec root dir.
Comment 2 Mackenzie Morgan 2008-11-18 22:51:49 UTC
No, that doesn't fix it.
Comment 3 Riccardo Magliocchetti 2008-11-19 13:14:13 UTC
This was my original patch and should work for you too :)

diff --git a/swfdec-gtk/swfdec_playback_pulse.c b/swfdec-gtk/swfdec_playback_pulse.c
index 5aa85f0..e867ac8 100644
--- a/swfdec-gtk/swfdec_playback_pulse.c
+++ b/swfdec-gtk/swfdec_playback_pulse.c
@@ -79,6 +79,7 @@ stream_write_callback (pa_stream *pa,
     g_printerr ("Failed to allocate fragment of size %d\n", (int)bytes);
     return;
   }
+  memset(frag, 0, bytes);
 
   /* Set up our fragment and render swfdec's audio into it. The swfdec audio
    * decoder renders deltas from the existing data in the fragment.
Comment 4 Mackenzie Morgan 2008-11-19 14:11:11 UTC
Should that be applied to clean sources alone, or should the previous patch and this one be combined?
Comment 5 Riccardo Magliocchetti 2008-11-19 22:38:04 UTC
(In reply to comment #4)
> Should that be applied to clean sources alone, or should the previous patch and
> this one be combined?

sorry, missed to mention that thisshould be applied to clean sources.

Comment 6 Mackenzie Morgan 2008-11-20 02:19:17 UTC
No, that doesn't get rid of it either.

Am I doing something wrong, maybe?  I modified swfdec and recompiled it, closed Firefox, and opened it back up, then tested it.  Should I be recompiling swfdec-mozilla after each recompile of swfdec as well or something?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.