Bug 1888

Summary: 800-byte pitch not allowed on r128
Product: xorg Reporter: Daniel Stone <daniel>
Component: Driver/rage128Assignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: michel, roland.mainz
Version: git   
Hardware: PowerPC   
OS: All   
URL: http://bugs.debian.org/148775
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
[FIXED_X11R68x] trivial patch roland.mainz: 6.8-branch+

Description Daniel Stone 2004-11-22 09:29:26 UTC 
Some clamshell iBooks have a pitch of 800 bytes, but this is not allowed by the
r128 driver, which claims that it must be *64, instead of *32.  While
contradictory to the ATI docs, having the smaller granularity allows the r128
driver to be used on these machines.  Patch (Debian #069, Ubuntu #020) follows
to allow the pitch in the first place, and change Xv allocation granularity to 8
byte instead of 16.  This patch has been present in every Debian version of
XFree86 4.3, and every Ubuntu version of XFree86 and X.Org, seemingly with no
problems.
Comment 1 Daniel Stone 2004-11-22 09:30:59 UTC 
Created attachment 1329 [details] [review]
[FIXED_X11R68x] trivial patch
Comment 2 Daniel Stone 2004-11-23 11:02:07 UTC 
Comment on attachment 1329 [details] [review]
[FIXED_X11R68x] trivial patch

make roland less angry
Comment 3 Daniel Stone 2004-11-23 14:05:43 UTC 
It should be mentioned that this patch was inspired by Michel Dänzer -- Michel,
does this look alright to commit?
Comment 4 Michel Dänzer 2004-11-24 13:53:16 UTC 
Yeah, looks good to me (and otherwise I can probably be blamed anyway ;).
Comment 5 Daniel Stone 2004-12-04 14:35:08 UTC 
Comment on attachment 1329 [details] [review]
[FIXED_X11R68x] trivial patch

committed to HEAD, please consider for 6.8.2
Comment 6 Roland Mainz 2004-12-11 15:28:37 UTC 
Comment on attachment 1329 [details] [review]
[FIXED_X11R68x] trivial patch

Approval for X11R6.8.x stable branch granted in the 2004-12-08
release-wranglers phone call.
Please don't commit, I'll do that myself...
Comment 7 Roland Mainz 2004-12-15 01:14:33 UTC 
Comment on attachment 1329 [details] [review]
[FIXED_X11R68x] trivial patch

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.88; previous revision: 1.365.2.87
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/drivers/ati/r128_driver.c,v  <-- 
r128_driver.c
new revision: 1.10.2.1; previous revision: 1.10
/cvs/xorg/xc/programs/Xserver/hw/xfree86/drivers/ati/r128_video.c,v  <-- 
r128_video.c
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment 8 Roland Mainz 2004-12-15 01:15:26 UTC 
Patch checked-in into Xorg trunk and X11R6.8.x stable branch...

... marking bug as FIXED.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.