Bug 18951

Summary: Chatstate "gone" sent repetitively
Product: Telepathy Reporter: Alban Crequy <alban.crequy>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/going-going-gone
Whiteboard:
i915 platform: i915 features:

Description Alban Crequy 2008-12-08 07:30:40 UTC 
What happened: Gabble sent repetitively the chat state "gone" as fast as my laptop could, each time the incoming text channel get closed by Mission Control because of the lack of handler, and re-spawned because it is a text channel.

What we should do:
- don't send a chat state if we never sent anything in the channel
- add a test for that
- is it possible to avoid the loop?
Comment 1 Will Thompson 2008-12-08 07:34:13 UTC 
MC's meant to call Destroy if the channel is looping.
Comment 2 Robert McQueen 2008-12-18 18:52:08 UTC 
Maybe so, but we shouldn't send gone if we never sent anything in the first place.
Comment 3 Robert McQueen 2008-12-18 18:53:48 UTC 
(indeed, the channel should start in a state where it's got no typing notification state at all, and never sends any states or includes them in messages, and only move out of that state and send notifications if the telepathy client calls any such notification methods on it, and this results in a message being sent)
Comment 4 Will Thompson 2009-06-02 10:34:13 UTC 
My branch 'going-going-gone' fixes this.
Comment 5 Guillaume Desmottes 2009-06-10 03:20:27 UTC 
Why did you add a declaration of emit_closed_and_send_gone? It's not used before its definition.
Comment 6 Will Thompson 2009-06-10 04:09:47 UTC 
No good reason; I pushed a patch removing it.
Comment 7 Will Thompson 2009-06-10 04:41:12 UTC 
Merged; will be in 0.7.29!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.