Bug 19031

Summary:

Server 1.6 dolt update (f3edc1fb) breaks compile on older versions on bash (see #18363)

Product:

xorg

Reporter:

Stuart Bennett <sb476>

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

CC:

cloos

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
Fix in git patch form, lest it be more convenient	none

Description Stuart Bennett 2008-12-11 16:08:16 UTC

The new version of dolt included in the server 1.6 betas uses bash syntax only available in newer versions of the shell, and when used with older bash the build breaks.  This is a known issue with the current git version of dolt, described in bug #18363.  Applying the fix from comment 9 of that bug to acinclude.m4 allows the xserver to build:

-        *) args+=("$arg")
+        *) args@<:@${#args[@]}@:>@="$arg" ;;

Comment 1 Stuart Bennett 2008-12-11 16:11:11 UTC

Created attachment 21070 [details] [review]
Fix in git patch form, lest it be more convenient

Comment 2 James Cloos 2008-12-12 01:58:08 UTC

Pushed to master as 7be6520d94df874c6bbd46d06a1830a12d0967f2.

Will nominate for 1.6.

Thanks.

Comment 3 James Cloos 2008-12-16 16:17:40 UTC

Cherry picked from master to the server-1.6-branch as c7fffe9e1354f816b6e2adedff045999fba9f1be.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.