Bug 19118

Summary: [G45] Missing images in Blender toolbar
Product: Mesa Reporter: Sven Arvidsson <sa>
Component: Drivers/DRI/i965Assignee: Eric Anholt <eric>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: Blender with missing images
Blender with software rendering, no problem

Description Sven Arvidsson 2008-12-16 15:17:11 UTC
Created attachment 21221 [details]
Blender with missing images

After bug 18907 was fixed, Blender no longer causes locks up, but the toolbars are missing images. 

I'm attaching a screenshot of the problem, and another one done in software rendering, where there's no problem.

System environment:
-- chipset: G45 / ICH10R
-- system architecture: 32-bit
-- Linux distribution: Debian unstable
-- Machine or mobo model: Asus P5Q-EM
-- Display connector: DVI
-- xf86-video-intel: e6479f96e5d8da39fcbb5376c4a66a1f924ec4e4
-- xserver: 1.5.2
-- mesa: 702b5b076b7591560e7e701e0c9ff2eeb30fa966
-- drm: c86d431fe6174b1c2de531929213ea7dbd92326d
-- kernel: for-airlied 66647dc60d16fae9f6963fd98b6d9baa1a8dac69
Comment 1 Sven Arvidsson 2008-12-16 15:17:47 UTC
Created attachment 21222 [details]
Blender with software rendering, no problem
Comment 2 Eric Anholt 2008-12-19 13:16:02 UTC
Do you know when this problem started?  Could you bisect?
Comment 3 Sven Arvidsson 2008-12-22 09:53:01 UTC
I have been trying to bisect this, but I'm getting a build error on the second to last revision to test.

Bisecting: 1 revisions left to test after this
[7216679c1998b49ff5b08e6b43f8d5779415bf54] i965: Accelerate depth textures with border color.

make[6]: Entering directory `/home/sa/Temp/intel/mesa/mesa/obj-i486-linux-gnu/dri/src/mesa/drivers/dri/i965'
make[6]: *** No rule to make target `depend', needed by `default'.  Stop.

Comment 4 Sven Arvidsson 2008-12-22 09:55:21 UTC
I guess the log can be useful too,

git-bisect start
# bad: [f83f5ec8f5f1159cfd0ec2596ceab725c073266e] Add do_row_3d for mipmapping 3D textures
git-bisect bad f83f5ec8f5f1159cfd0ec2596ceab725c073266e
# good: [d533da2db873942b3f8676a754b8be3c9718bedf] i965: Cope with batch getting flushed in the middle of batchbuffer emits.
git-bisect good d533da2db873942b3f8676a754b8be3c9718bedf
# bad: [242c0cb543183682f4f023a6f1948630dc5bae09] mesa: fix logic error in GLSL linker when looking for main() shaders
git-bisect bad 242c0cb543183682f4f023a6f1948630dc5bae09
# bad: [39df336635e0c756f73f6b0b58f1d811fabc6d13] glx: indent -br -i3 -npcs --no-tabs indirect_transpose_matrix.c
git-bisect bad 39df336635e0c756f73f6b0b58f1d811fabc6d13
# good: [db9ba91971a1f279b040b30bf8fd5d13a70f0a03] intel: Don't advertise unsupported extensions on pre-965 hardware
git-bisect good db9ba91971a1f279b040b30bf8fd5d13a70f0a03
# bad: [24748268a3ac7bedc2c9ae5bf76c4c741d539f80] mesa: fix asst. issues in _mesa_texstore_argb8888()
git-bisect bad 24748268a3ac7bedc2c9ae5bf76c4c741d539f80
# good: [902727b7e3eb3c2c9bcddf1d55d3c95c73377cf3] mesa: Pass the context to query object delete cb to avoid null dereference.
git-bisect good 902727b7e3eb3c2c9bcddf1d55d3c95c73377cf3
# bad: [5e9cb42aa662022c63563b4bc7f9e1d99f6d81ee] i965: Add missing intel_pixel_draw.c symlink to fix build.
git-bisect bad 5e9cb42aa662022c63563b4bc7f9e1d99f6d81ee
# good: [9aec1288eeae8e87adc9a99f377be536892941b2] i915: Accelerate depth textures with border color.
git-bisect good 9aec1288eeae8e87adc9a99f377be536892941b2
Comment 5 Sven Arvidsson 2008-12-24 11:51:42 UTC
TFM suggested I use "git bisect skip", after doing so, I'm left with these:

There are only 'skip'ped commit left to test.
The first bad commit could be any of:
7216679c1998b49ff5b08e6b43f8d5779415bf54
91221483a633d6230a4f8d2500ed180428754215
5e9cb42aa662022c63563b4bc7f9e1d99f6d81ee
We cannot bisect more!
Comment 6 Eric Anholt 2008-12-31 00:35:57 UTC
Thanks for the bisect!  91221483a633d6230a4f8d2500ed180428754215 was at fault.

Fixed in:
commit bfebeffc0045266d354a36968336337e099a9f27
Author: Eric Anholt <eric@anholt.net>
Date:   Wed Dec 31 00:29:49 2008 -0800

    intel: Share passthrough transform setup between glBitmap and glDrawPixels.
    
    The DrawPixels path was missing glViewport care, so blender's toolbar icons
    would go to the wrong places.
    
    Bug #19118.
Comment 7 Adam Jackson 2009-08-24 12:31:20 UTC
Mass version move, cvs -> git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.