Bug 1926

Summary: Don't unregister XSelectInput() when unregistering IM callback
Product: xorg Reporter: Egbert Eich <eich>
Component: Lib/XlibAssignee: Egbert Eich <eich>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: roland.mainz
Version: unspecified   
Hardware: PA-RISC (HP)   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Fix
none
[FIXED_X11R68x] Fix (update) roland.mainz: 6.8-branch+

Description Egbert Eich 2004-11-26 05:46:41 UTC 
Unregistering events in XSelectInput() when unregistering IM
filter callbacks may be a bad idea as others may be interested
in this event. Removed the call to XSelectInput() altogether
as we are in root window anyway.
Comment 1 Egbert Eich 2004-11-26 05:48:24 UTC 
Created attachment 1385 [details] [review]
Fix

Patch by Lubos Lunak.
(Committed already, submitted for nomination).
Comment 2 Egbert Eich 2004-12-06 10:18:43 UTC 
Created attachment 1482 [details] [review]
[FIXED_X11R68x] Fix (update)

Remove the code in question entirely (including comment saying why it is a bad
idea).
Comment 3 Roland Mainz 2004-12-11 15:31:09 UTC 
Comment on attachment 1482 [details] [review]
[FIXED_X11R68x] Fix (update)

Approval for X11R6.8.x stable branch granted in the 2004-12-08
release-wranglers phone call.
Please don't commit, I'll do that myself...
Comment 4 Roland Mainz 2004-12-12 18:25:08 UTC 
Comment on attachment 1482 [details] [review]
[FIXED_X11R68x] Fix (update)

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.25; previous revision: 1.365.2.24
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/lib/X11/imInsClbk.c,v  <--  imInsClbk.c
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment 5 Roland Mainz 2004-12-12 18:25:42 UTC 
Patch has been commited to Xorg trunk and X11R6.8.x stable branch...

... marking bug as FIXED (please reopen if there are any issues left).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.