Bug 19307

Summary: 1.2.10 dbus-sysdeps-util-unix.c compile failure OS X 10.5
Product: dbus Reporter: Glen Whitney <gwhitneycom1>
Component: coreAssignee: Havoc Pennington <hp>
Status: RESOLVED FIXED QA Contact: John (J5) Palmieri <johnp>
Severity: major    
Priority: high CC: grahame, walters
Version: 1.2.x   
Hardware: PowerPC   
OS: Mac OS X (All)   
i915 platform: i915 features:

Description Glen Whitney 2008-12-28 14:24:27 UTC
As of release 1.2.10, the source file dbus-sysdeps-util-unix.c will not compile under Mac OS X 10.5, because the function "openlog" is undeclared.  On Mac OS X 10.5, "openlog" is declared in the header <syslog.h>.  If the line

   #include <syslog.h>

is added in the section of #includes at the top of this file, it compiles and dbus makes normally.

I did not include a patch because (a) it's a one-liner, but mostly (b) I have no way of knowing if this header exists on other operating systems, or how in the build system for dbus you would want to go about checking if this #include is necessary.

I appreciate it if someone is able to properly tailor the #includes in a future release of dbus.  Many thanks, Glen
Comment 1 Grahame Bowland 2009-01-06 00:21:30 UTC
I get the same compilation error on a Fedora core 3 machine, adding the syslog.h include fixes it.
Comment 2 Colin Walters 2009-01-06 14:34:47 UTC
commit 510a307da0ce3e63361d0b9b8db4df3f564a1955
Author: Colin Walters <walters@verbum.org>
Date:   Tue Jan 6 17:34:20 2009 -0500

    Bug 19307: Add missing syslog include

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.