Bug 19330

Summary: SetupRequest and QueryExtension are missing padding
Product: XCB Reporter: Antoine Latter <aslatter>
Component: ProtocolAssignee: xcb mailing list dummy <xcb>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Antoine Latter 2008-12-29 17:06:31 UTC
SetupRequest and QueryExtension are missing padding required by the protocol.

Here's a patch:


diff --git a/src/xproto.xml b/src/xproto.xml
index 89df956..519912d 100644
--- a/src/xproto.xml
+++ b/src/xproto.xml
@@ -156,6 +156,7 @@ authorization from the authors.
     <field type="CARD16" name="protocol_minor_version" />
     <field type="CARD16" name="authorization_protocol_name_len" />
     <field type="CARD16" name="authorization_protocol_data_len" />
+    <pad bytes="2" />
     <list type="char" name="authorization_protocol_name">
       <fieldref>authorization_protocol_name_len</fieldref>
     </list>
@@ -2006,6 +2007,7 @@ authorization from the authors.
   <request name="QueryExtension" opcode="98">
     <pad bytes="1" />
     <field type="CARD16" name="name_len" />
+    <pad bytes="2" />
     <list type="char" name="name">
       <fieldref>name_len</fieldref>
     </list>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.