Bug 19483

Summary:	Regression - poppler head does not render a document that was fine with 0.8.7
Product:	poppler	Reporter:	Frederik Gladhorn <gladhorn>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	sho
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch to resolve this problem

Description Frederik Gladhorn 2009-01-09 11:01:50 UTC

The PDFs found at http://new.fantasyflightgames.com/edge_minisite_sec.asp?eidm=7&esem=4
did render with poppler-qt4 0.8.7-1 (kubuntu) but are shown mostly empty with current HEAD.
For example http://new.fantasyflightgames.com/ffg_content/StarCraft/sc_bw_rules.pdf
shows up empty for me.

Comment 1 Frederik Gladhorn 2009-01-09 11:07:03 UTC

The revision I tried is 6dd77338d16f80760ae32ff9f3e2be9768fc0c49 as of Jan 09th 2009

Comment 2 Albert Astals Cid 2009-01-09 11:15:14 UTC

Koji can you have a look? The problem is caused by your Color Management patch.

Comment 3 Frederik Gladhorn 2009-01-09 11:41:29 UTC

I confirm - git bisect shows that the commit causing the bug is the enabling of color management:
commit 18d584158a781fecb4f696b01fb4d17803ce7d7a

Comment 4 Koji Otani 2009-01-10 08:04:40 UTC

Created attachment 21871 [details] [review]
patch to resolve this problem

Comment 5 Koji Otani 2009-01-10 08:20:19 UTC

The sample PDF use CMYK Color Profile.
My Color Managemnent Patch uses 'double' as data format with cmsDoTransform of libcms.
But, I've found that with a CMYK Color Profile and 'double' data format cmsDoTransform produces wrong results. 

So, to resolve this problem, 'byte' should be used as data format for cmsDoTransform.

I've attached a patch to resolve this problem.

Comment 6 Albert Astals Cid 2009-01-10 09:14:32 UTC

Good Work! Patch commited. Btw here Adobe Reader 8.1.3 renderes almost all the first page character in black. The whole pdf is in general darker, can you see if that's also a problem in our color management code? Or maybe it's a problem in their side or in my Adobe Reader installation

Comment 7 Koji Otani 2009-01-10 20:09:58 UTC

I think that thers is no problem in our color management code about this.

I think that Adobe Reader in Linux renderes this pdf too dark.
Adobe Reader in Windows renderes it brighter than in Linux.
But, poppler renderes it still a bit brighter in default than Adobe Reader,
 because of display color profile that is builtin sRGB profile of liblcms.
If you want it more darker, please download sRGB profile from http://www.color.org/srgbprofiles.xalter,
 and install that as /usr/share/poppler/ColorProfile/display.icc or ~/.xpdf/ColorProfile/display.icc.
So, poppler renders the pdf file as same as Adobe Reader in Windows do.
Of course, it's the best to install a color profile of your display if you can get it.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.