Bug 19563

Summary:

Apply partial matches for option

Product:

xorg

Reporter:

Alexey Ten <alexeyten+deb>

Component:

Server/Input/XKB

Assignee:

Daniel Stone <daniel>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

CC:

atorkhov, peter.hutterer, svu

Version:

unspecified

Keywords:

patch

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

Bug Blocks:

14022

Attachments:

Description	Flags
patch	none
git-formatted patch	none

Description Alexey Ten 2009-01-14 12:09:56 UTC

XkbRF_GetComponents ignores partial matched rules (rules matched to *) for option rules. This behavior prevent rules like one below to work.

layout[2] option    = symbols
*         misc:typo = +typo(base)

Attached patch resolves this issue.

Comment 1 Alexey Ten 2009-01-14 12:10:27 UTC

Created attachment 21988 [details] [review]
patch

Comment 2 Peter Hutterer 2009-01-14 14:11:40 UTC

Alexey, can you please provide a git-formatted patch? just commit it and then do git-format-patch HEAD~1 and attach the 0001-....patch to this bugreport. It makes life a lot easier for us. Please also make sure you add a reference to this bug in the commit message (for example like this: http://cgit.freedesktop.org/xorg/xserver/commit/?id=56efbc0986e782da45addb05ece9f456d41d7a90)

Comment 3 Alexey Ten 2009-01-14 14:48:55 UTC

Created attachment 21991 [details] [review]
git-formatted patch

Comment 4 Sergey V. Udaltsov 2009-01-14 15:04:52 UTC

I've tested the patch locally, it worked.

Consider it as signed by me.

Comment 5 Peter Hutterer 2009-01-14 15:09:10 UTC

Pushed as e695be2ab7eb1361b204f98c3da872eff58ad6b5. Thanks for the patch!

Comment 6 Sergey V. Udaltsov 2009-09-30 15:49:06 UTC

*** Bug 24048 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.