Bug 19604

Summary: s-t-b fails to build on Intrepid
Product: system-tools-backends Reporter: Michael Hasselmann <michaelh>
Component: initAssignee: Carlos Garnacho Parro <carlosg>
Status: RESOLVED FIXED QA Contact: Carlos Garnacho Parro <carlosg>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: Adds missing 3rd paramater to open in dispatcher/main.c

Description Michael Hasselmann 2009-01-16 06:51:21 UTC
Created attachment 22032 [details] [review]
Adds missing 3rd paramater to open in dispatcher/main.c

When building system-tools-backends from source gcc will complain about wrong usage of "open" (in dispatcher/main.c), and abort.

Checked with gcc version 4.3.2 (Ubuntu 4.3.2-1ubuntu11)

glibc introduced a check for the usage of "open" (see bits/fcntl2.h and also http://gcc.gnu.org/ml/gcc-help/2008-12/msg00255.html for more details)

Patch attached.
Comment 1 Murray Cumming 2009-01-18 08:11:14 UTC
Michael, please add a ChangeLog entry in the patch in future, in general.
Comment 2 Luca Ferretti 2009-07-22 04:09:44 UTC
This issue is no longer reproducible in 2.6.1 release.

Was it fixed?
Comment 3 Milan Bouchet-Valat 2009-08-19 02:08:52 UTC
Yeah, that was fixed by Carlos Garnacho in 	38645998a2bfbf81bb9c5312f9e0969549a0cb16 in March, and is in 2.6.1.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.