Bug 1965

Summary:

PCI scanning on IA64 ends up in an endless loop if no PCI bus is found.

Product:

xorg

Reporter:

Egbert Eich <eich>

Component:

Server/DDX/Xorg

Assignee:

Egbert Eich <eich>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

high

CC:

roland.mainz

Version:

6.8.1

Hardware:

PA-RISC (HP)

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
[FIXED_X11R68x] Fix	roland.mainz: 6.8-branch+

Description Egbert Eich 2004-11-30 00:25:08 UTC

The Chipset specific PCI bus probing code for IA64 calls scanpci while being
called from scanpci itself. Normally scanpci has gathered PCI information at
that point and will just return this instead of recursively walking thru the
code again. 
However if no PCI devices have been detected the test for recursive calling
fails - thus it will end up in an endless recursive loop.

Comment 1 Egbert Eich 2004-11-30 00:26:55 UTC

Created attachment 1425 [details] [review]
[FIXED_X11R68x] Fix

This patch adds another test to make sure scanpci bails early when called
before.

Comment 2 Egbert Eich 2004-11-30 00:39:45 UTC

Committed for CVS head.

Comment 3 Roland Mainz 2004-12-08 05:55:59 UTC

Comment on attachment 1425 [details] [review]
[FIXED_X11R68x] Fix

Approved in the 2004-12-06 release-wranglers conference call (having a comment
what the change does would be nice).
Please do not commit it yourself, I'll do that later today...

Comment 4 Roland Mainz 2004-12-14 21:52:34 UTC

Comment on attachment 1425 [details] [review]
[FIXED_X11R68x] Fix

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.78; previous revision: 1.365.2.77
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/os-support/bus/Pci.c,v  <--  Pci.c
new revision: 1.3.2.1; previous revision: 1.3
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.