Bug 19667

Summary: [i915] Glean test/fbo render to 1D texture work incorrecly
Product: Mesa Reporter: zhao jian <jian.j.zhao>
Component: Drivers/DRI/i915Assignee: Eric Anholt <eric>
Status: RESOLVED MOVED QA Contact:
Severity: normal    
Priority: medium CC: christophe.prigent, mengmeng.meng
Version: unspecified   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 20277    
Attachments: xorg.conf
xorg.0.log
test result of fbo

Description zhao jian 2009-01-20 19:57:36 UTC
Created attachment 22120 [details]
xorg.conf

System Environment:
--------------------------
Host:           x-945gm
Arch:           i386
OSD:            Fedora release 9 (Sulphur)
Kernel:         2.6.28
Libdrm:         (master)18d3cc076b53f2032eed1f9a4b21947f4cb9e4e7
Mesa_stable:            (intel-2008-q4)200fa9165d7078a6f36c5c9d3e0c997c2438bde3
Xorg:           7.2
Xserver_stable:  (server-1.6-branch)  251d0d8090322b2c9dc0c8b7bef001f338d19433
Xf86_video_intel_stable: 
(xf86-video-intel-2.6-branch)5cd65d965c8ed388275fe2084553302aad601d4a

Bug detailed description:
-------------------------
On 915 or 945 machines, run the test case of fbo in glean cases. The log is I run in 945gm with UXA. 

Reproduce Steps:
1. xinit&
2. gnome-session&
3. run the glean cases.
Comment 1 zhao jian 2009-01-20 19:58:05 UTC
Created attachment 22121 [details]
xorg.0.log
Comment 2 zhao jian 2009-01-20 19:58:51 UTC
Created attachment 22122 [details]
test result of fbo
Comment 3 Gordon Jin 2009-01-21 01:04:37 UTC
This happens on i915 while 13759 happens on i965. Filing separate bugs as it may go through different code path.
Comment 4 zhao jian 2009-09-14 23:58:15 UTC
This still exist on 945GM and 945GME in KMS with the following output. Test with 
Libdrm:		(master)67e4172394a88d4922fb8d9c7c3d96ce7e02c5a6
Mesa:		(master)57d16c4cc37689710f951cb13981e2efc160cd23
Xserver:		(master)8fb3fa28a5a1b36cdaad38055a607400828b9e1c
Xf86_video_intel:	(master)efbcf29dd1a1ca058b7a2a93f0685102c06c9369
Kernel:       (drm-intel-next)7e61615857c6fb3afbcb43f5c4e97511a923f5a8

fbo test: Test OpenGL Extension GL_EXT_framebuffer_object

GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  NOTE perf[0] = 23.4522 MB/s, which is using glCopyTexImage2D
fbo:  NOTE perf[1] = 22.3023 MB/s, which is using FBO
fbo:  FAIL rgba8, db, z24, s8, win+pmap, id 33
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  NOTE perf[0] = 23.46 MB/s, which is using glCopyTexImage2D
fbo:  NOTE perf[1] = 22.3295 MB/s, which is using FBO
fbo:  FAIL rgba8, db, z24, s8, win+pmap, id 34
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  FAIL rgba8, db, z24, s8, win+pmap, id 105
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  NOTE perf[0] = 23.4614 MB/s, which is using glCopyTexImage2D
fbo:  NOTE perf[1] = 22.3188 MB/s, which is using FBO
fbo:  FAIL rgb8, z24, win+pmap, id 208
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  NOTE perf[0] = 23.4618 MB/s, which is using glCopyTexImage2D
fbo:  NOTE perf[1] = 22.3534 MB/s, which is using FBO
fbo:  FAIL rgb8, z24, accrgb16, win+pmap, slow, id 209
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  NOTE perf[0] = 23.4091 MB/s, which is using glCopyTexImage2D
fbo:  NOTE perf[1] = 22.2585 MB/s, which is using FBO
fbo:  FAIL rgb8, db, z24, win+pmap, id 210
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  NOTE perf[0] = 23.4475 MB/s, which is using glCopyTexImage2D
fbo:  NOTE perf[1] = 22.3012 MB/s, which is using FBO
fbo:  FAIL rgb8, db, z24, accrgb16, win+pmap, slow, id 211
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  NOTE perf[0] = 23.4772 MB/s, which is using glCopyTexImage2D
fbo:  NOTE perf[1] = 22.3199 MB/s, which is using FBO
fbo:  FAIL rgb8, db, z24, win+pmap, id 212
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  NOTE perf[0] = 23.397 MB/s, which is using glCopyTexImage2D
fbo:  NOTE perf[1] = 22.3355 MB/s, which is using FBO
fbo:  FAIL rgb8, db, z24, accrgb16, win+pmap, slow, id 213
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  NOTE perf[0] = 23.4083 MB/s, which is using glCopyTexImage2D
fbo:  NOTE perf[1] = 22.3354 MB/s, which is using FBO
fbo:  FAIL rgb8, z24, s8, win+pmap, id 214
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is not supported
  depth = 0, stencil = 0
  (0, 0) = [0.000000, 0.000000, 0.000000], is expected to be[1.000000, 0.000000, 0.000000]
FAILURE: Render to single texture failed (at tfbo.cpp:840)
  mode = 0
  depth = 1, stencil = 0
  (14, 0) = [0.749020, 0.749020, 0.749020], is expected to be[1.000000, 1.000000, 1.000000]
FAILURE: Render to depth texture failed (at tfbo.cpp:1145)
fbo:  NOTE perf[0] = 23.4292 MB/s, which is using glCopyTexImage2D
fbo:  NOTE perf[1] = 22.2719 MB/s, which is using FBO
fbo:  FAIL rgb8, z24, s8, accrgb16, win+pmap, slow, id 215
	6 tests passed, 2 tests failed.
GL_EXT_framebuffer_object is supported
GL_(log cut by piglit)
Comment 5 Eric Anholt 2010-09-24 11:34:30 UTC
The test was just broken.  Fixed now:

commit 9fdd8d9d1fc56178c950ba8fbca8abfb2e9d8b96
Author: Eric Anholt <eric@anholt.net>
Date:   Fri Sep 24 11:29:22 2010 -0700

    glean/tfbo: Put lines in the middle of the pixel, not the edge.
    
    GL lets the implementation be +/- a pixel on line location.  It was
    getting rounded down on the intel driver, so the lines weren't drawn
    to 1D FBOs.  This should have a better chance on drivers in general.
Comment 6 zhao jian 2010-12-29 22:13:25 UTC
It still fails on Pineview now with the same error info. Tested with: 

Libdrm:		(master)2.4.23-4-gbad5242a59aa8e31cf10749e2ac69b3c66ef7da0
Mesa:		(master)df4d83dca4618eb7077637865763d3e9ab750d11
Xserver:		(master)xorg-server-1.9.99.901-49-gefcb63d0ce43f96d0ac02b6f4a480dfd2374fc84
Xf86_video_intel:		(master) 2.13.902-11-g7667ad8432c032aec3a2aa004fc4dfc1877971b3
Cairo:		(master)a4ae7d59be2e545afc30c35b2235b89860e2003a
Kernel:	(drm-intel-next) 608ca70d22c0ea0d52aa71f52b8e326055c274d1
Comment 7 zhao jian 2010-12-29 23:28:21 UTC
some more info is I tested with both the glean source contained in piglit test and the glean source from glean.git.sourceforge.net.
Comment 8 GitLab Migration User 2019-09-18 19:32:25 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/673.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.