| Summary: | make XErrorDB location configurable | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Alexander Gottwald <ago> | ||||||
| Component: | Lib/Xlib | Assignee: | Xorg Project Team <xorg-team> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | high | CC: | jg | ||||||
| Version: | unspecified | ||||||||
| Hardware: | x86 (IA32) | ||||||||
| OS: | Linux (All) | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexander Gottwald
2004-12-01 05:00:21 UTC
Created attachment 1435 [details] [review] proposed patch Use environment variable XERRORDB as location and fall back to compiletime default if it is not set /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.555; previous revision: 1.554 /cvs/xorg/xc/lib/X11/ErrDes.c,v <-- ErrDes.c new revision: 1.3; previous revision: 1.2 fixed in HEAD Might I propose another addition to this: Use $XERRORDB like shown here. If not found, then look for ProjectRoot/lib/X11/$LANG/XErrorDB . If not found, then use the standard ProjectRoot/lib/X11/XErrorDB . This way we can support translated XErrorDB files by default. Created attachment 1467 [details] [review] document XERRORDB environment variable added documentation of XERRORDB to X.man Commited documentation patch to HEAD /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.568; previous revision: 1.567 /cvs/xorg/xc/doc/man/general/X.man,v <-- X.man new revision: 1.5; previous revision: 1.4 ***WHY*** should the XErrorDB location be configurable? Without the motivation, we can't tell if this is a feature we want... I need a relocatable libX11 for Windows. The package should be completly relocatable. I can already relocate rgb.txt, XLOCALEDIR, XKEYSYMDB and the fonts but XErrorDB is always searched in places defined at compiletime. We worry about possible security issues; and it is far from clear this should be an option on other platforms. This patch raises security questions especially for SUID root programs. I don't think it is save to allow the user to override this for SUID root programs even though this is read only. Yes, and you've mentioned more potential problems here. Wrapped the handling of XERRORDB with #ifdef WIN32 and removed the patch from the X man page. Removed the 6.8.2 approval flag too. /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.585; previous revision: 1.584 /cvs/xorg/xc/lib/X11/ErrDes.c,v <-- ErrDes.c new revision: 1.4; previous revision: 1.3 /cvs/xorg/xc/doc/man/general/X.man,v <-- X.man new revision: 1.6; previous revision: 1.5 The code is only used on WIN32. So there's no security problem on other OS marking as fixed |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.