Bug 1987

Summary:

HAVE_SYSV_IPC should be defined when building libc_wrapper.c on Solaris

Product:

xorg

Reporter:

Alan Coopersmith <alan.coopersmith>

Component:

Server/DDX/Xorg

Assignee:

Alan Coopersmith <alan.coopersmith>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

high

CC:

roland.mainz

Version:

git

Hardware:

All

OS:

Solaris

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
[FIXED_X11R68x] Add -DHAVE_SYSV_IPC when compiling on Solaris	roland.mainz: 6.8-branch+

Description Alan Coopersmith 2004-12-02 00:02:20 UTC

The Xorg server does not export the xf86shmget(), xf86shmat(), xf86shmctl(), 
and xf86shmdt() functions to drivers on Solaris, but they are required by 
certain drivers.

To get these, we simply need to add the HAVE_SYSV_IPC define to the
Imakefile in os-support/sunos.

This define simply defines the needed functions so that drivers can call them.
If a driver doesn't call them, the functions go unused, so there should be
no risk of any regression to anything else in the system by enabling this.

Comment 1 Alan Coopersmith 2004-12-02 00:02:54 UTC

Taking myself...

Comment 2 Alan Coopersmith 2004-12-03 19:03:30 UTC

Created attachment 1462 [details] [review]
[FIXED_X11R68x] Add -DHAVE_SYSV_IPC when compiling on Solaris

Comment 3 Alan Coopersmith 2004-12-05 21:07:04 UTC

Fix committed to head branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.572; previous revision: 1.571
/cvs/xorg/xc/programs/Xserver/hw/xfree86/os-support/sunos/Imakefile,v  <-- 
Imakefile
new revision: 1.4; previous revision: 1.3

This is also fixed in the Solaris bundled Xorg packages in Solaris build s10_74,
under Sun bug id #6202551

Test Case:
When built on Solaris, 'nm /usr/X11/bin/Xorg | grep xf86shm' should show 
entries for each of these functions:
    xf86shmget, xf86shmat, xf86shmctl, and xf86shmdt

Comment 4 Roland Mainz 2004-12-08 05:56:19 UTC

Comment on attachment 1462 [details] [review]
[FIXED_X11R68x] Add -DHAVE_SYSV_IPC when compiling on Solaris

Approved in the 2004-12-06 release-wranglers conference call.
Please do not commit it yourself, I'll do that later today...

Comment 5 Roland Mainz 2004-12-14 22:15:02 UTC

Comment on attachment 1462 [details] [review]
[FIXED_X11R68x] Add -DHAVE_SYSV_IPC when compiling on Solaris

Patch checked-in into X11R6.8.x stable branch:

cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.79; previous revision: 1.365.2.78
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/os-support/sunos/Imakefile,v  <-- 
Imakefile
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.