Bug 19919

Summary:	crashed with AttributeError in on_contact_memberships_changed()
Product:	Telepathy	Reporter:	Guillaume Desmottes <guillaume.desmottes>
Component:	butterfly	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	critical
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Guillaume Desmottes 2009-02-02 14:52:02 UTC

Original bug report:
https://bugs.edge.launchpad.net/ubuntu/+source/telepathy-butterfly/+bug/222336

Occured while adding a MSN contact. If I open Pidgin, I have a synchronisation difference between my local list and the server list of contacts

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/pymsn/client.py", line 252, in property_changed
    self._dispatch(method_name, contact)
  File "/usr/lib/python2.5/site-packages/pymsn/event/__init__.py", line 44, in _dispatch
    if event_handler._dispatch_event(name, *args):
  File "/usr/lib/python2.5/site-packages/pymsn/event/__init__.py", line 65, in _dispatch_event
    handler(*params)
  File "/usr/lib/python2.5/site-packages/butterfly/aliasing.py", line 98, in on_contact_memberships_changed
    handle = ButterflyHandleFactory(self._conn_ref(), 'contact',
AttributeError: 'ButterflyConnection' object has no attribute '_conn_ref'

Comment 1 Olivier Le Thanh Duong 2009-02-02 16:11:49 UTC

The _conn_ref attribute doesn't exist at all and we shoud only pass self to ButterflyHandleFactory. Here is a short patch that fix the problem:
http://repo.or.cz/w/telepathy-butterfly.git?a=shortlog;h=refs/heads/bug19919

Comment 2 Jonny Lamb 2009-02-02 16:54:22 UTC

commit c09a8a65d1f8a944d547c48f5a155c9069069f1e
Author: Olivier Le Thanh Duong <olivier@lethanh.be>
Date:   Tue Feb 3 00:55:27 2009 +0100

    Fix on_contact_memberships_changed (fd.o #19919)

    Corrected the parameter given to ButterflyHandleFactory
    in on_contact_memberships_changed which caused the
    AttributeError.

    Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.