Bug 20157

Summary: PendingConnection should produce a QSharedPointer<Connection> with no parent
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: tp-qtAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: enhancement    
Priority: high    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Simon McVittie 2009-02-17 04:13:51 UTC
12:10 < smcv> andrunko, oggis_: in PendingConnection, should the 
              ConnectionManager really be the parent of the resulting 
              Connection, btw?
12:10 < oggis_> no it shouldn't
12:10 < oggis_> definitely not
12:10 < oggis_> it should return a shared pointer to a connection with no 
                parent at all
12:10 < oggis_> parents and shared pointers generally don't mix
12:10 < oggis_> when a parent deletes its children, the shared pointers will 
                become dangling
Comment 1 Simon McVittie 2009-02-17 04:59:12 UTC
Fixed in git already, sorry for the spam

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.