Bug 20337

Summary:	Jingle tests shouldn't assume stream names.
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	high
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	23653
Bug Blocks:
Attachments:	Stop Gabble getting confused if the other end lies about content's media types

Description Will Thompson 2009-02-26 14:00:58 UTC

I tried to add the attached fix to Gabble, but then jingle/test-content-adding-removal.py broke. Seems to be because JingleTest2.outgoing_call_reply assumes that the audio stream is called 'stream1' and the video stream is called 'stream2'. It shouldn't.

Probably the correct fix is to make outgoing_call_reply take the entire session-initiate query (rather than just its sid) and possibly accept_video, accept_audio booleans.

Setting priority to "high" because a broken test suite is an unhappy test suite. I will probably do this, but I am filing a bug in case I forget.

Comment 1 Will Thompson 2009-02-26 14:02:01 UTC

Created attachment 23338 [details] [review]
Stop Gabble getting confused if the other end lies about content's media types

Comment 2 Will Thompson 2009-09-02 10:59:52 UTC

Comment on attachment 23338 [details] [review]
Stop Gabble getting confused if the other end lies about content's media types

This patch is no longer necessary, and I've largely fixed the tests' dependence on particular stream names in another branch (about to set as blocking this bug).

Comment 3 Will Thompson 2009-09-03 10:48:26 UTC

Fixed in 0.8.2 and 0.9.0.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.