Bug 20384

Summary: --enable-debug build failures : dix/events.c:ET_DeviceKeyPress & xkbAccess.c:
Product: xorg Reporter: Jason Vas Dias <jason.vas.dias>
Component: Server/GeneralAssignee: Peter Hutterer <peter.hutterer>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: Solaris   
i915 platform: i915 features:
Description Flags
patch allowing xserver to build with '--enable-debug' none

Description Jason Vas Dias 2009-02-28 14:39:08 UTC
Created attachment 23394 [details] [review]
patch allowing xserver to build with '--enable-debug'

Hi ! This is my first post here -
so first I'd like to thank everyone for the great work on the new X server 1.6 ,
which I've been attempting to compile and get working, on this platform:
hardware:  x86-64 ( AMD TL-64 x2 (dual core k8) 2.2Ghz, 2GB RAM, Radeon X1200 Mobility xf86-videeo-radeonhd supported video card)
OS:        linux-2.6.29-rc6-tip-x86
GCC:       4.3.3
GLIBC:     2.9.90

Having git-pulled the latest versions of xorg ( xorg/libX*, xorg/app/*, xorg/driver/xf86-{input-{keyboard,mouse,synaptics,evdev},video-{radeonhd,vesa,vga}}
xorg/data/*, xorg/app/*, xserver ) as of 2009-02-28, and rebuilt everything OK,
with vanilla './autogen.sh --prefix=/usr --libdir=/usr/lib64' I find that Xorg
starts up and displays OK, but is unable to receive ANY input from
keyboard or mouse, so just freezes.  

This was on my own "latest of everything" Linux distribution (origally Gentoo 
based) - but on Fedora Rawhide, the situation is the same - X freezes on startup  - I will raise a different bug on this issue if I am unable to resolve -
this bug is for being unable to add the '--enable-debug' flag to xserver configure command line.

Attempting to enable debug in the Xorg server by adding the '--enable-debug'
configuration flag makes xserver unable to build without this patch, because
of these gcc errors:
events.c:3678: error: 'ET_DeviceKeyPress' undeclared (first use in this function)
--- dix/events.c~       2009-02-24 00:37:26.000000000 -0500
+++ dix/events.c        2009-02-28 16:57:33.000000000 -0500
@@ -3678 +3678 @@
-               (((event->type == ET_KeyPress)||(event->type == ET_DeviceKeyPress)) ? "down" : "up"));
+               (((event->type == ET_KeyPress)||(event->type == DeviceKeyPress)) ? "down" : "up"));
--- ./xkb/xkbAccessX.c~ 2009-02-24 00:37:26.000000000 -0500
+++ ./xkb/xkbAccessX.c  2009-02-28 17:05:44.000000000 -0500
@@ -136 +136 @@
-               (event->type == ET_KeyPress ? "down" : "up"));
+               (event.type == ET_KeyPress ? "down" : "up"));

Just thought I should let you know !

Anyone have any success getting xserver-1.6 to work on a linux-2.6.29-rc3+
( Fedora 11 / Gentoo latest ) ?
Comment 1 Peter Hutterer 2009-02-28 23:07:06 UTC
Thanks for the patch, looks good.

Please re-submit as a git-formatted patch to ensure authorship, etc.
See http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches for more details.

btw. 1.6.99.* is pre-1.7, not server 1.6. The server we ship in Fedora is 1.6.0.
Comment 2 Peter Hutterer 2009-03-02 22:55:40 UTC
Pushed as e0ed9f16d0ab871f3209837f54055446503c4108.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.