Bug 2051

Summary: ASF/WMV confusion
Product: shared-mime-info Reporter: Marco Pesenti Gritti <mpgritti>
Component: freedesktop.org.xmlAssignee: Jonathan Blandford <jrb>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: bugzilla, sbrabec
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: wmv.patch
typos.patch
wmv.patch
typos.patch

Description Marco Pesenti Gritti 2004-12-10 08:31:23 UTC
As from this gnome-vfs bug report:

http://bugzilla.gnome.org/show_bug.cgi?id=154893

ASF magic matches also WMV files.
Comment 1 Stanislav Brabec 2005-03-29 07:57:55 UTC
Created attachment 2237 [details] [review]
wmv.patch

I am not an expert on video formats, but attached patch helps at least for some
WMV files.
Comment 2 Stanislav Brabec 2005-03-29 07:59:38 UTC
Created attachment 2238 [details] [review]
typos.patch

And a patch for partially related typos. It also adds missing Danish from CVS
to package and fixes it.
Comment 3 derek 2005-08-05 07:01:34 UTC
I've also found adding the following to work well.    
<alias type="video/x-ms-wmv"/>
<alias type="video/x-ms-wma"/>
to the ASF entry.

(WMA is a new type I added to freedesktop.org.xml - pretty much WMV)
Comment 4 Ilya Konstantinov 2005-09-27 15:50:07 UTC
Indeed Nautilus doesn't seem to be impressed by sub-classing but simply aliasing
works well.

Remember to run "update-mime-database /usr/share/mime" (or whatever your
system-wide directory is) after editing freedesktop.org.xml if you're manually
patching. To make Nautilus recognize the changes, restart it (killall nautilus).
Comment 5 Stanislav Brabec 2005-09-29 03:20:48 UTC
I guess that in Nautilus 2.12 (and latest shared-mime-info) it is fixed:
http://bugzilla.gnome.org/show_bug.cgi?id=171595
(And the need to restart, probably too.)
Comment 6 Stanislav Brabec 2006-03-16 03:07:34 UTC
Created attachment 4954 [details] [review]
wmv.patch

Updated version of patch for 0.17.
Comment 7 Stanislav Brabec 2006-03-16 03:20:45 UTC
After the wmv.patch patch, nautilus consistently considers files as WMV, not as ASF.

The typos.patch is still valid, too.

Rationale for sub-class-of instead of alias (cut and paste from the specs):

alias elements indicate that the type is also sometimes
known by another name, given by the type attribute. For
example, audio/midi has an alias of
audio/x-midi. Note that there should not be a
mime-type element defining each alias; a single
element defines the canonical name for the type and lists all its aliases.

sub-class-of elements indicate that any data of this
type is also some other type, given by the type
attribute.

A type is a subclass of another type if any instance of the first type is
also an instance of the second. For example, all image/svg files are also
text/xml, text/plain and application/octet-stream files. Subclassing is about
the format, rather than the catagory of the data (for example, there is no
'generic spreadsheet' class that all spreadsheets inherit from).
Comment 8 Stanislav Brabec 2006-03-16 03:28:01 UTC
Created attachment 4957 [details] [review]
typos.patch

Updated version of typos patch. it also fixes and adds Danish translation,
which is missing in the tarball, but present in the CVS.
Comment 9 Bastien Nocera 2006-03-16 05:10:25 UTC
For typos.patch:

2006-03-15  Bastien Nocera  <hadess@hadess.net>

        * configure.in: also install the Danish translation, patch from
        Stanislav Brabec <sbrabec@suse.cz> (Closes: #2051)

2006-03-15  Bastien Nocera  <hadess@hadess.net>

        * da.po:
        * fr.po: Fix a couple of typos, patch from Stanislav Brabec
        <sbrabec@suse.cz> (Closes: #2051)
Comment 10 Bastien Nocera 2006-03-16 05:14:24 UTC
2006-03-15  Bastien Nocera  <hadess@hadess.net>

        * freedesktop.org.xml.in: Add a mime-type for WMA (Closes: #2178),
        and make it and WMV sub-classes of ASF (Closes: #2051), patches from
        Stanislav Brabec <sbrabec@suse.cz>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.