Bug 20601

Summary: Tests could have an assertEquals function
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: trivial    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Simon McVittie 2009-03-11 05:59:59 UTC 
12:55 < daf> +            channel_props.get('Interfaces', ()), \
12:55 < daf> +            channel_props.get('Interfaces')
12:55 < daf> what does the second argument win us?
12:56 < daf> oh, it tells us what the value is if the assertion fails
12:56 < daf> the code would be shorter if you did:
12:56 < daf> def assertEquals(expected, value):
12:57 < daf>     assert expected == value, "expected: %r; got: %r" % (expected, 
             value)
12:57 < wjt> daf: that's true of every test
12:57 < smcv> RESOLVED LATER
Comment 1 Dafydd Harries 2009-03-11 06:06:32 UTC 
Another cleanup we could do at the same time is to add the Requests interface to the connection proxy.
Comment 2 Will Thompson 2009-04-22 05:28:47 UTC 
Daf implemented these.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.