Bug 20702

Summary:	[PATCH] rendering non-square pixels in pdftoppm
Product:	poppler	Reporter:	Michael K. Johnson <a1237>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	GPLv2 or later patch to implement non-square rendering in pdftoppm second version of patch

Description Michael K. Johnson 2009-03-16 20:00:05 UTC

Created attachment 23944 [details] [review]
GPLv2 or later patch to implement non-square rendering in pdftoppm

I have a need to render non-square pixels in pdftoppm.  I'm not sure yet
whether I'd rather specify x and y resolution explicitly or x and y
scaling separately; due to some variation in my input it's certainly
possible that I'll actually want to use both.

I have implemented it to add -rx and -ry options to specify the x and y
resolution separately.

I have implemented -scale-to-x and -scale-to-y to specify the final x
and y sizes in pixels separately.

I also have modified the man page, including making it clear that the
-scale-to option takes arguments in pixels.

I'd like to mention that the source code was easy to read and modify --
thanks for the good work!  This patch is relative to current git.

I agree to license this patch under GPLv2 or later, as requested in README.contributors file.

Comment 1 Michael K. Johnson 2009-03-18 19:28:42 UTC

Created attachment 24021 [details] [review]
second version of patch

The first version of the patch has a bug for the -r, -rx and -ry cases that
I inadvertently added while adding -scale-to-x and -scale-to-y and did not
realize that I hadn't re-tested -rx and -ry.  That is now fixed, and I have
now tested -r, -rx -ry, -rx -scale-to-y, -scale-to-x -ry, and -scale-to
arguments and all seem to work correctly with the second version of the
patch.

Comment 2 Albert Astals Cid 2009-03-21 08:16:31 UTC

Will be available in poppler 0.12 (next non bugfix release of poppler), it would be good if you subscribe to http://lists.freedesktop.org/mailman/listinfo/poppler

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.