Bug 20716

Summary:	[fixed in git] Add --with-dbus-binding-tool option to use an external dbus-binding-tool
Product:	dbus	Reporter:	Peter Korsgaard <jacmet>
Component:	GLib	Assignee:	Rob Taylor <rob.taylor>
Status:	RESOLVED FIXED	QA Contact:	John (J5) Palmieri <johnp>
Severity:	enhancement
Priority:	medium	CC:	r.schwebel, walters
Version:	1.2.x	Keywords:	patch
Hardware:	Other
OS:	Linux (All)
URL:	http://git.collabora.co.uk/?p=user/smcv/dbus-glib-smcv.git;a=shortlog;h=refs/heads/20716-with-dbus-binding-tool
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch adding --with-dbus-binding-tool configure option Peter's patch in git-am format

Description Peter Korsgaard 2009-03-17 15:27:41 UTC

Created attachment 23972 [details] [review]
patch adding --with-dbus-binding-tool configure option

Cross compilation fix. dbus-binding-tool needs to run on the host, but gets
compiled for the target. Add an option to use an external program
(host version) instead, similar to the --with-introspect-xml option.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
---
 configure.ac                           |    5 +++++
 dbus/examples/Makefile.am              |    4 ++--
 dbus/examples/statemachine/Makefile.am |    4 ++--
 test/core/Makefile.am                  |    6 +++---
 test/interfaces/Makefile.am            |   12 ++++++------
 tools/Makefile.am                      |    2 +-
 6 files changed, 19 insertions(+), 14 deletions(-)

We're using this patch in Buildroot (http://buildroot.net) and PTXdist (http://www.pengutronix.de/software/ptxdist/index_en.html)

Comment 1 Simon McVittie 2009-04-15 13:24:50 UTC

I'm not a reviewer for this project, but the patch looks good.

Comment 2 Simon McVittie 2009-04-15 13:32:49 UTC

For your reviewing convenience:

http://git.collabora.co.uk/?p=user/smcv/dbus-glib-smcv.git;a=shortlog;h=refs/heads/20716-with-dbus-binding-tool

If you approve, merge the 20716-with-dbus-binding-tool branch from:

git://git.collabora.co.uk/git/user/smcv/dbus-glib-smcv.git

Comment 3 Simon McVittie 2009-04-27 02:47:12 UTC

Created attachment 25185 [details] [review]
Peter's patch in git-am format

Comment 4 Colin Walters 2009-05-06 11:00:15 UTC

Simon please do count yourself as a reviewer =)

I wonder if it would make sense instead to in the cross compilation case compile two versions of dbus-binding-tool, one we use internally and one for the target?  Not sure offhand how tricky that is to do with automake.

Or are configure arguments how these types of problems are typically handled?

Anyways on this patch, the only part I'm a bit unsure about is the "DBUS_BINDING_TOOL=\$\(top_builddir\)" magic given the layers of quoting and shell interpretation in here, but if it works now and solves a problem for someone let's put this patch in.

Comment 5 Peter Korsgaard 2009-05-06 11:07:14 UTC

The thing with compiling dbus-binding-tool for both the host and the target is basically what we're using the patch for. First we compile dbus-glib for the host to get a dbus-binding-tool program we can run on the build host, and then we pass that program to the compilation for the target (./configure --with-dbus-binding-tool=<path/to/host/dbus-binding-tool>).

Thanks.

Comment 6 Simon McVittie 2009-05-28 10:07:48 UTC

Pushed, thanks.

Comment 7 Simon McVittie 2009-07-20 06:11:53 UTC

Fixed in 0.82

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.