Bug 20730

Summary:	comply with telepathy-spec 0.17.21: always allow leaving groups
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	butterfly	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Simon McVittie 2009-03-18 10:45:03 UTC

+++ This bug was initially created as a clone of Bug #20728 +++

Rob wrote, in Bug #16886:
> The spec (and MUC implementation in Gabble) implies that you can leave a MUC
> room with a message by using RemoveMembers([self_handle], "you guys suck")
> [...] this in fact doesn't work. tp-glib doesn't allow removing even the self
> handle from the MUC, because the _CAN_REMOVE flag isn't set.

telepathy-spec 0.17.21 mandates this behaviour (and also the same for StreamedMedia calls). Please ensure that RemoveMembers (and RemoveMembersWithReason) always allow the self-handle to leave Butterfly's Group text channels.

Comment 1 Jonny Lamb 2010-03-08 04:35:20 UTC

(In reply to comment #0)
> Rob wrote, in Bug #16886:
> > The spec (and MUC implementation in Gabble) implies that you can leave a MUC
> > room with a message by using RemoveMembers([self_handle], "you guys suck")
> > [...] this in fact doesn't work. tp-glib doesn't allow removing even the self
> > handle from the MUC, because the _CAN_REMOVE flag isn't set.
> 
> telepathy-spec 0.17.21 mandates this behaviour (and also the same for
> StreamedMedia calls). Please ensure that RemoveMembers (and
> RemoveMembersWithReason) always allow the self-handle to leave Butterfly's
> Group text channels.

I'm a little confused -- are you saying that butterfly doesn't do this, or are you saying "make sure butterfly works like this"?

A small glance at the RemoveMembers code seems to suggest it should work as documented in the spec, but I could easily be wrong. I'm just a little confused what you're actually saying.

Comment 2 Jonny Lamb 2010-03-08 04:42:16 UTC

12:39 < wjt> jonnylamb: smcv is saying “make sure butterfly does this”
12:39 < wjt> jonnylamb: because everyone claimed that gabble worked like that, but it didn't
12:40 < jonnylamb> Okay, so it might already work. I'll test it out.

Comment 3 Jonny Lamb 2010-03-12 15:35:49 UTC

Since my work on text channels in butterfly, this should work fine.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.