Bug 20775

Summary:	Avatars: turn requirements into properties, add to ConnectionManager, add to .manager file
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-spec	Assignee:	Eitan Isaacson <eitan.isaacson>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	low	CC:	will
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/eitan/telepathy-spec.git;a=shortlog;h=refs/heads/undraft-proto-avatars
Whiteboard:	merged
i915 platform:		i915 features:
Bug Depends on:	20774
Bug Blocks:	23148, 31686

Description Simon McVittie 2009-03-20 11:35:58 UTC

Avatar requirements have a couple of deficiencies:

* avatar requirements cannot currently be discovered while offline
* the protocol's ideal width/height cannot be discovered

Proposed enhancements, in order:

* make MinimumAvatarWidth, etc., into properties so we can use GetAll for them
* add RecommendedAvatarWidth and ...Height
* add a property on the ConnectionManager (or an interface thereof) to discover avatar requirements
* cache the value of that property in the .manager file

This branch currently implements only the first two:

http://git.collabora.co.uk/?p=user/smcv/telepathy-spec-smcv.git;a=shortlog;h=refs/heads/avatars

Comment 1 Simon McVittie 2009-11-04 09:46:53 UTC

(In reply to comment #0)
> * make MinimumAvatarWidth, etc., into properties so we can use GetAll for them
> * add RecommendedAvatarWidth and ...Height

Done in 0.17.x

> * add a property on the ConnectionManager (or an interface thereof) to discover
> avatar requirements
> * cache the value of that property in the .manager file

Being tracked in Bug #20774.

Comment 2 Eitan Isaacson 2010-11-16 12:35:32 UTC

This branch undrafts Proto.I.Avatars.

I'll make a tp-glib branch as well with proper TpBaseProtocol additions.

http://git.collabora.co.uk/?p=user/eitan/telepathy-spec.git;a=shortlog;h=refs/heads/undraft-proto-avatars

Comment 3 Simon McVittie 2010-11-18 06:24:55 UTC

> +    <tp:added version="0.19.14">(as stable API)</tp:added>

No, it wasn't :-P (0.21.UNRELEASED would be correct)

Like I said on the other bug, I'd like a proof-of-concept branch for a CM before undrafting this - preferably Haze, since it's the only popular CM where this interface is non-trivial.

Comment 4 Eitan Isaacson 2010-11-18 09:44:18 UTC

(In reply to comment #3)
> > +    <tp:added version="0.19.14">(as stable API)</tp:added>
> 
> No, it wasn't :-P (0.21.UNRELEASED would be correct)
> 

Squashed the change above.

Comment 5 Simon McVittie 2010-11-19 03:38:22 UTC

You changed the <tp:added/> in Protocol.xml. Please revert that, and change the correct file instead :-P

Other than that, this looks fine to merge: thanks for picking this feature up.

Comment 6 Eitan Isaacson 2010-11-19 11:47:55 UTC

(In reply to comment #5)
> You changed the <tp:added/> in Protocol.xml. Please revert that, and change the
> correct file instead :-P
> 
> Other than that, this looks fine to merge: thanks for picking this feature up.

Corrected and merged, thanks!

Comment 7 Simon McVittie 2010-11-24 09:40:12 UTC

*** Bug 30085 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.