Bug 2092

Summary:	_radeon_texrect_stage looks broken
Product:	Mesa	Reporter:	Felix Kühling <fxkuehl>
Component:	Drivers/DRI/R100	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	high
Version:	git
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Felix Kühling 2004-12-16 06:52:23 UTC

I just hacked up a texture normalizing pipeline stage for the savage driver. I
started by copying the radeon_texrect stage. In the end I had confirmed that my
stage was running but it did not take effect. When I checked t_vb_texmat.c I saw
why: When the stage installs its output in the VB it needs to change
VB->AttribPtr too e.g.:

VB->AttribPtr[VERT_ATTRIB_TEX0+i] = VB->TexCoordPtr[i] = &store->texcoord[i];

As this is missing in the _radeon_texrect_stage I assume it must be broken right
now. Can anyone confirm this.

Comment 1 Andreas Stenglein 2004-12-20 05:02:17 UTC

It looks like texrect works with the old (==current), template based
radeon_swtcl.c code.
But it doesnt work with t_vertex based code. Your change seems to fix that.

Comment 2 Andreas Stenglein 2004-12-20 10:06:52 UTC

btw., while experimenting with texrect I noticed some missing debugstrings in
radeon_tcl.c

Index: Mesa/src/mesa/drivers/dri/radeon/radeon_tcl.c
===================================================================
RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/radeon/radeon_tcl.c,v
retrieving revision 1.10
diff -u -r1.10 radeon_tcl.c
--- Mesa/src/mesa/drivers/dri/radeon/radeon_tcl.c
+++ Mesa/src/mesa/drivers/dri/radeon/radeon_tcl.c
@@ -491,7 +491,10 @@
    "Texgen unit 0",
    "Texgen unit 1",
    "Texgen unit 2",
-   "User disable"
+   "User disable",
+   "texture rectangle unit 0",
+   "texture rectangle unit 1",
+   "texture rectangle unit 2"
 };

Comment 3 Roland Scheidegger 2005-09-14 08:56:11 UTC

Seems to got fixed in cvs when the driver was converted to t_vertex.

Comment 4 Adam Jackson 2009-08-24 12:22:56 UTC

Mass version move, cvs -> git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.