Bug 2110

Summary: Mesa build problem in 6.8.2rc1
Product: xorg Reporter: Kevin E. Martin <kem>
Component: Server/Ext/GLXAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: roland.mainz
Version: 6.8.2Keywords: regression
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Build failure output
none
[FIXED_X11R68x] Patch to workaround build problems roland.mainz: 6.8-branch+

Description Kevin E. Martin 2004-12-19 08:24:02 UTC
I've been running build and run tests for RC1, and found a build problem with
gcc 2.96 in Mesa.  The problem is that "(void)rmesa" was added to LOCAL_VARS to
eliminate compiler warnings; however, in t_dd_dmatmp.h and t_dd_dmatmp2.h, there
are additional declarations after LOCAL_VARS.  This causes the build to fail on
gcc 2.96.

Note this is _not_ a problem with gcc 3.4.2.
Comment 1 Kevin E. Martin 2004-12-19 08:26:45 UTC
Created attachment 1568 [details]
Build failure output

This is the compiler output from the first build failure.
Comment 2 Kevin E. Martin 2004-12-19 08:28:32 UTC
Created attachment 1569 [details] [review]
[FIXED_X11R68x] Patch to workaround build problems

This is a patch to workaround the problem, but it might better to add a
ELIMINATE_WARNINGS define with the list of "(void)var;"'s that need to be used
to eliminate compiler warnings, and then add ELIMINATE_WARNINGS to the
appropriate functions in t_dd_dmatmp.h and t_dd_dmatmp2.h.
Comment 3 Kevin E. Martin 2005-01-10 09:14:35 UTC
Comment on attachment 1569 [details] [review]
[FIXED_X11R68x] Patch to workaround build problems

This was approved on the 10 Jan 2005 release wranglers call.  I marked it with
a "?" so that it can be easily tracked for inclusion in the next release
candidate.
Comment 4 Roland Mainz 2005-01-12 17:07:01 UTC
Comment on attachment 1569 [details] [review]
[FIXED_X11R68x] Patch to workaround build problems

Approval for commit into X11R6.8.x stable branch granted in the 2005-01-10 Xorg
release wranglers phone call (I'll do the commit myself in a few mins).
Comment 5 Roland Mainz 2005-01-12 17:11:45 UTC
Comment on attachment 1569 [details] [review]
[FIXED_X11R68x] Patch to workaround build problems

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.119; previous revision: 1.365.2.118
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/extras/Mesa/src/mesa/drivers/dri/r200/r200_tcl.c,v  <-- 
r200_tcl.c
new revision: 1.1.1.2.2.2; previous revision: 1.1.1.2.2.1
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/extras/Mesa/src/mesa/drivers/dri/radeon/radeon_swtcl.c,v  <-- 
radeon_swtcl.c
new revision: 1.1.1.3.2.2; previous revision: 1.1.1.3.2.1
/cvs/xorg/xc/extras/Mesa/src/mesa/drivers/dri/radeon/radeon_tcl.c,v  <-- 
radeon_tcl.c
new revision: 1.1.1.2.2.2; previous revision: 1.1.1.2.2.1
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment 6 Adam Jackson 2005-04-03 14:46:46 UTC
mass update: this bug was applied to the stable 6.8 branch but NOT to HEAD!
Comment 7 Alan Coopersmith 2005-06-04 11:52:37 UTC
Applied to HEAD as well now, closing.

CVSROOT:	/cvs/xorg
Module name:	xc
Changes by:	alanc@gabe.freedesktop.org	05/06/04 11:42:17

Log message:
  2005-06-04  Alan Coopersmith  <alan.coopersmith@sun.com>
  
  	* extras/Mesa/src/mesa/drivers/dri/r200/r200_tcl.c
  	* extras/Mesa/src/mesa/drivers/dri/radeon/radeon_swtcl.c
  	* extras/Mesa/src/mesa/drivers/dri/radeon/radeon_tcl.c
  	Sync with 6.8.2 branch:
  	Bugzilla #2110 (https://bugs.freedesktop.org/show_bug.cgi?id=2110)
  	attachment #1569 [details] [review] (https://bugs.freedesktop.org/attachment.cgi?id=1569):
  	Fix build bustage in MESA/DRI code with gcc 2.96.
  	Patch by Kevin E. Martin <kem@freedesktop.org>

Modified files:
      ./:
        ChangeLog 
      xc/extras/Mesa/src/mesa/drivers/dri/r200/:
        r200_tcl.c 
      xc/extras/Mesa/src/mesa/drivers/dri/radeon/:
        radeon_swtcl.c radeon_tcl.c 
  
  Revision      Changes    Path
  1.972         +11 -0     xc/ChangeLog
  1.2           +42 -15    xc/extras/Mesa/src/mesa/drivers/dri/r200/r200_tcl.c
  1.2           +14 -10    xc/extras/Mesa/src/mesa/drivers/dri/radeon/radeon_swtcl.c
  1.2           +15 -4     xc/extras/Mesa/src/mesa/drivers/dri/radeon/radeon_tcl.c

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.