| Summary: | spec 0.17.23 will make Requests interface mandatory | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | idle | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | major | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/wjt/telepathy-idle-wjt.git;a=shortlog;h=refs/heads/channel-manager | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 17843, 20731 | ||
|
Description
Simon McVittie
2009-04-14 04:44:55 UTC
Jonathon Jongsma and I have implemented Requests in Idle; see URL. Things not blocking merge: The first patch would have been much, much easier to review if it was four patches: * make IdleIMFactory into a TpChannelManager * make IdleIMFactory stop being a TpChannelFactoryIface * rename IdleIMFactory to reflect its new role * rename idle-im-factory.c to idle-im-manager.c (In Gabble, equivalents of the first two were done separately, and equivalents of the latter two haven't been done at all. Perhaps we should in 0.9.) One day, we should re-indent Idle so it doesn't make me want to claw my eyes out. _iface_connecting and _iface_disconnected shouldn't be commented out, they should be deleted entirely. connection_status_changed_cb should probably switch(status). The class should be ported to use the "pimpl" idiom (set up self->priv in init then use self->priv->bongs), like (say) TpChannel does. Ship it. Merged the channel-manager branch; thanks for the review! <http://git.collabora.co.uk/?p=telepathy-idle.git;a=commit;h=6a224e80ae> I'll fix up the trivia now; the reindenting and self->priv->...-ification can come later.x |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.