Bug 21168

I started looking at this: http://cgit.collabora.com/git/user/wjt/telepathy-idle-wjt.git/log/?h=contacts

Got bogged down in splitting aliasing stuff into a separate file.

Binned the Aliasing refactoring, just implemented Contacts.

I'm pretty sure Idle is the last CM not to support Contacts, so this was the main thing getting in the way of deleting fallback paths from tp-glib.

Created attachment 49350 [details] [review]
Connection: use TP_STRUCT_TYPE_ALIAS_PAIR

Created attachment 49351 [details] [review]
Implement GetAliases()

This went unimplemented for however long!

Created attachment 49352 [details] [review]
Connection: replace constructor with constructed.

Created attachment 49353 [details] [review]
Add a TpContactsMixin

Created attachment 49354 [details] [review]
Contacts: support Aliasing

Created attachment 49355 [details] [review]
Contacts: add stub support for ContactInfo

Review of attachment 49350 [details] [review]:

+1

Review of attachment 49351 [details] [review]:

small coding stype, otherwise +1

::: src/idle-connection.c
@@ +1194,3 @@
+  GError *error = NULL;
+
+  if (!tp_handles_are_valid(repo, handles, FALSE, &error))

missing space _valid ()

Review of attachment 49352 [details] [review]:

+1

Review of attachment 49353 [details] [review]:

small coding style, otherwise +1

::: src/idle-connection.c
@@ +227,3 @@
 	priv->msg_queue = g_queue_new();
+
+	tp_contacts_mixin_init((GObject *) obj, G_STRUCT_OFFSET(IdleConnection, contacts));

missing space _init () and OFFSET ()

@@ +409,2 @@
 	g_queue_free(priv->msg_queue);
+	tp_contacts_mixin_finalize(object);

missing space _finalize ()

@@ +483,3 @@
 	g_object_class_install_property(object_class, PROP_PASSWORD_PROMPT, param_spec);
 
+	tp_contacts_mixin_class_init(object_class, G_STRUCT_OFFSET(IdleConnectionClass, contacts));

missing space _init () and OFFSET ()

Review of attachment 49354 [details] [review]:

+1

Review of attachment 49355 [details] [review]:

+1

Thanks, fixed those points and merged.

It'll be in 0.1.11 or 0.2.0 or whatever it ends up being called.