Bug 21295

Summary: If no alias is set then local JID part is returned as the alias instead of the full JID
Product: Telepathy Reporter: Marco Barisione <marco.barisione>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/full-jid-as-fallback-alias
Whiteboard:
i915 platform: i915 features:

Description Marco Barisione 2009-04-20 05:44:19 UTC 
When retrieving aliases the Telepathy spec says “This SHOULD only return cached
aliases, falling back on the handle name if none is present.”.
Gabble doesn't follow this, if no alias is set gabble returns only the local part of the JID instead of the full jid.
Comment 1 Will Thompson 2009-04-25 03:41:59 UTC 
Fixed in the linked branch

 src/conn-aliasing.c                           |  102 +++++++++----------------
 src/muc-channel.c                             |   15 ++++-
 tests/twisted/vcard/test-alias-empty-vcard.py |    4 +-
 tests/twisted/vcard/test-vcard-cache.py       |    4 +-
 4 files changed, 55 insertions(+), 70 deletions(-)
Comment 2 Guillaume Desmottes 2009-04-28 03:57:01 UTC 
create_room_identity: a comment explaining the logic of this check would be good:
+  if (source == GABBLE_CONNECTION_ALIAS_FROM_JID)

Except that +1
Comment 3 Will Thompson 2009-04-28 06:16:16 UTC 
(In reply to comment #2)
> create_room_identity: a comment explaining the logic of this check would be
> good:
> +  if (source == GABBLE_CONNECTION_ALIAS_FROM_JID)

Having done so, merged. Thanks!

commit 654246b152e630dae459b76be4fca0472e3a7e56
Merge: 147fa58 fc2a2e9
Author: Will Thompson <will.thompson@collabora.co.uk>
Date:   Tue Apr 28 14:13:03 2009 +0100

    Merge branch 'full-jid-as-fallback-alias'
    
    Fixes fd.o#21295.
    
    Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

 src/conn-aliasing.c                           |  102 +++++++++----------------
 src/muc-channel.c                             |   18 ++++-
 tests/twisted/vcard/test-alias-empty-vcard.py |    4 +-
 tests/twisted/vcard/test-vcard-cache.py       |    4 +-
 4 files changed, 58 insertions(+), 70 deletions(-)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.