Bug 2134

Summary:	ListAcivatablesServices.patch
Product:	dbus	Reporter:	Marcin Krzyzanowski <krzak>
Component:	core	Assignee:	Havoc Pennington <hp>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	high
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch ListActivatableNames this one should work, adapted to new API. Not sure about tests.

Description Marcin Krzyzanowski 2004-12-22 04:00:32 UTC

from dbus@freedesktop.org

>> org.freedesktop.DBus.ListServices() show only activated service, because 
>> I get no other possibility to gather information about services which 
>> are available but not activated at the moment I wrote a patch for 
>> "ListServices" which make return list with both activated and not yet 
>> activated services.
>> 
>> What do you think about such solution. Or maybe there is other way to 
>> get all available services but I miss it ?


I think a better approach would introduce a new call
ListActivatableServices(), because listing only active services is also
a useful thing to do - so keeping the existing ListServices() is
important.

Comment 1 Marcin Krzyzanowski 2004-12-22 04:01:21 UTC

Created attachment 1588 [details] [review]
patch

Comment 2 Colin Walters 2005-06-15 23:16:23 UTC

This patch has some minor style issues; in particular you need to use spaces
after parens, and brackets go on their own line (e.g. instead of:)
+  do {

The braces should be indented two spaces.  Basically GNU style.

get_activatable_services should probably be named like bus_get_activatable or
bus_get_activatable_services.

Other than that it looks OK to me.  Can you fix these issues?

Comment 3 John (J5) Palmieri 2005-08-24 22:03:03 UTC

Did this ever get in?  Patch most likely needs to be fixed up to apply to latest
code if it was added.

Comment 4 Marcin Krzyzanowski 2006-06-18 12:57:58 UTC

Created attachment 5966 [details] [review]
ListActivatableNames

updated patch against current cvs

Comment 5 Marcin Krzyzanowski 2006-06-18 16:25:42 UTC

Created attachment 5968 [details] [review]
this one should work, adapted to new API. Not sure about tests.

Comment 6 John (J5) Palmieri 2006-08-25 14:40:00 UTC

This has been added to recent versions of D-Bus

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.