Bug 21576

Created attachment 25500 [details]
XorgLog.txt

Created attachment 25501 [details]
XorgConf.txt

Created attachment 25502 [details]
kdm.log

Created attachment 25503 [details]
20090504-Xorg.log.1

Created attachment 25504 [details]
20090504-Xorg.log.2

Yifei, can you reproduce this on 945GM?

We can't reproduce it with upstream code on our 945GM.

Adjusting severity: crashes & hangs should be marked critical.

Also I'm a little confused about the summary; it sounds like regular VT switch was broken as well?  Or was it just VT switch after resuming from hibernate?

Anyway, please try upstream bits as Gordon suggests and let us know.  Thanks.

Still, we cannot reproduce it on our 945GM with:
distro:          Fedora 9
Libdrm:                (master)1bae8844cafd70f6196116f6e84b0f36c069e976
Mesa:           (master)53c2cc8fefa07723fc456d94eda292e201c41dae
xserver:                (master)c2b668e6fff11c52f2a3f0dc3f4d1fc2c5bcf3e6
xf86_video_intel:               (master)8d27247829fe4f55691ce68f9f4b14810fb34b32
kernel:                2.6.30-rc4

hibernate works fine, and vt switch works fine too after/before hibernate.

Yeah, this works well for me on an AspireOne...

Spoke too soon.. my machine hard hung shortly after returning from hibernate...  investigating.

Ah no I think something else was broken in my environment (was running some debug code).  Resume from hibernate appears ok with current bits.

Arg no, right after I hit commit on my last comment it hung again...  

(In reply to comment #14)
> Arg no, right after I hit commit on my last comment it hung again...  
How about doing the hibernation/resume under the console mode and then start X?Does the system still hang after starting X?
Thanks.

Created attachment 27321 [details] [review]
Restore the modeset for every activated crtc

Will you please try the attached patch on the latest linus git tree and see whether the issue still exists?
   
Thanks.

Ping Bryce?

This patch solved same resume issue on my pc (intel DG45ID)

Created attachment 27404 [details]
dmesg_after_w_patch

I have other bug related to resume on this pc.
http://bugzilla.kernel.org/show_bug.cgi?id=13710

ykzhav, note that I forwarded this from a ubuntu reporter, ari197.  I am not experiencing this bug myself.

I have asked ari197 to subscribe to this bug, and now have provided .debs of the git version of the driver including your patch for them to test with.

According to the discussion/comments I make some changes about the patch in comment #16. Now the patch set is already sent to intel-gfx mailing list.
    >http://lists.freedesktop.org/archives/intel-gfx/2009-July/003255.html
    >http://lists.freedesktop.org/archives/intel-gfx/2009-July/003256.html
    >http://lists.freedesktop.org/archives/intel-gfx/2009-July/003257.html

    Patch 1: resumes the modesetting for every activated crtc
    Patch 2: disable the unused connectors while resuming the modesetting
    Patch 3: Split the suspend/resume into KMS/UMS path to avoid resuming the modesetting registers twice in KMS mode.

thanks.

Since the mentioned patch set is already shipped, the bug will be marked as resolved.
   >Patch 1/3: commit 354ff96772540d2e836194bf14dd9c05c274055c
Author: Zhao Yakui <yakui.zhao@intel.com>
Date:   Wed Jul 8 14:13:12 2009 +0800
    drm/i915: Restore the KMS modeset for every activated CRTC
   >Patch 2/3: commit af4fcb574efa90373b02ae0bb8b54d710c32eeb4
Author: Zhao Yakui <yakui.zhao@intel.com>
Date:   Wed Jul 8 14:13:13 2009 +0800
    drm: Disable the unused connectors explicitly when resuming with KMS.
   >Patch 3/3: commit fccdaba4317604602e5802c3afc4021f2fb8132e
Author: Zhao Yakui <yakui.zhao@intel.com>
Date:   Wed Jul 8 14:13:14 2009 +0800
    drm/i915: Avoid saving/restore the modesetting registers twice in KMS mode

   If the issue still exists after the test, please reopen it.

   Thanks.