Bug 21644

Summary: git version of xcb-proto crashes 'awesome'
Product: XCB Reporter: Mariusz Ceier <mceier>
Component: ProtocolAssignee: xcb mailing list dummy <xcb>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Mariusz Ceier 2009-05-09 08:00:20 UTC 
I crashes in code like this:

xcb_size_hints_t size_hints;
xcb_get_wm_normal_hints_reply(connection,
  xcb_get_wm_normal_hints_unchecked(connection,win),&size_hints, NULL);

or

xcb_wm_hints_t wm_hints;
xcb_get_wm_hints_reply(connection,
  xcb_get_wm_hints_unchecked(connection,win),&wm_hints, NULL);

so I think it isn't 'awesome' bug.

It is caused by commit fe7b12db4fc0e95f3eef038581bf2154e1727c7a
"Correct the length calculation for the value field of GetPropertyReply."

After doing revert 'awesome' didn't crash.
Comment 1 Julien Danjou 2009-05-09 08:47:44 UTC 
This commits changes the value returned by xcb_get_property_value_length().. which breaks xcb-icccm in case where the format is != 8.
Comment 2 Julien Danjou 2009-05-09 09:04:18 UTC 
commit 85c7984f110dabb23ebaef367bcf6df96ad34377
Author: Julien Danjou <julien@danjou.info>
Date:   Sat May 9 18:03:28 2009 +0200

    icccm: fix compatibility with libxcb > 1.2
    
    The get property value proto changed so we do not have to worry about
    formats. Reflect that change.
    
    Signed-off-by: Julien Danjou <julien@danjou.info>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.