Bug 21670

Summary: [855GM] busted tiling with opengl apps
Product: xorg Reporter: Rémi Cardona <remi>
Component: Driver/intelAssignee: Eric Anholt <eric>
Status: VERIFIED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium CC: jbarnes
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Screenshot of the desktop with glxgears running (no compositor)
none
Xorg.0.log
none
dmesg none

Description Rémi Cardona 2009-05-10 23:18:59 UTC
Created attachment 25717 [details]
Screenshot of the desktop with glxgears running (no compositor)

I'm putting this in the 2D driver because there are errors in the X log...

current X stack :
 - libdrm : 11b60973bca1bc9bbda44be4c695e22d28d8ca4a (2.4.9 + 4 patches from master)
 - xf86-video-intel : 77153d690a3673fdee7bef8e567816b754c43081 (2.7 branch)
 - xorg-server : 1.6.1 without patches
 - mesa : 7.4 branch as of last week
 - kernel : 2.6.30-rc4-00002-g79f11c1 (drm-intel-next branch)

So far, everything seems to work ok (including Xv) and the perceived performance is really good.

Screenshot shows the bug pretty clearly.

Thanks
Comment 1 Rémi Cardona 2009-05-10 23:19:49 UTC
Created attachment 25718 [details]
Xorg.0.log
Comment 2 Rémi Cardona 2009-05-10 23:21:37 UTC
Created attachment 25719 [details]
dmesg
Comment 3 Gordon Jin 2009-05-10 23:32:07 UTC
The sysmpton looks similar to bug#18873 and bug#20473. But only this log says:
(EE) intel(0): Failed to set tiling on front buffer: Invalid argument
Comment 4 Eric Anholt 2009-05-26 21:16:39 UTC
Looks like this fix, in for-review and intel-gfx@lists.freedesktop.org:

commit e76a16deb8785317a23cca7204331af053e0fb4e
Author: Eric Anholt <eric@anholt.net>
Date:   Tue May 26 17:44:56 2009 -0700

    drm/i915: Fix tiling pitch handling on 8xx.
    
    The pitch field is an exponent on pre-965, so we were rejecting buffers
    on 8xx that we shouldn't have.  915 got lucky in that the largest legal
    value happened to match (8KB / 512 = 0x10), but 8xx has a smaller tile width
    Additionally, we programmed that bad value into the register on 8xx, so the
    only pitch that would work correctly was 4096 (512-1023 pixels), while other
    would probably give bad rendering or hangs.
    
    Signed-off-by: Eric Anholt <eric@anholt.net>
    
    fd.o bug #20473.

Comment 5 Rémi Cardona 2009-05-28 14:12:09 UTC
Confirming. Thanks for fixing this :)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.