| Summary: | get_contact_statuses should not be allowed to fail | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Will Thompson <will> |
| Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | xclaesse |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=next-presence | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 31668 | ||
| Attachments: | TpPresenceMixinGetContactStatusesFunc: remove the GError argument | ||
|
Description
Will Thompson
2009-05-18 07:03:50 UTC
Created attachment 64110 [details] [review] TpPresenceMixinGetContactStatusesFunc: remove the GError argument It is useless since handles are already guaranteed to be valid. Comment on attachment 64110 [details] [review] TpPresenceMixinGetContactStatusesFunc: remove the GError argument Review of attachment 64110 [details] [review]: ----------------------------------------------------------------- ::: telepathy-glib/presence-mixin.c @@ +976,2 @@ > > + g_hash_table_iter_init (&iter, contact_statuses); tp-glib should still check whether contact_statuses is NULL, rather than just crashing if the CM returns NULL. (Maybe it should fill in "unknown" for all handles if the CM returns NULL? Or just leave it out of the attribute dictionary.) Branch updated Looks fine for next. Thanks, merged. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.