| Summary: | vcard/test-vcard-race.py is racy | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Will Thompson <will> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | critical | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/daf/telepathy-gabble;a=shortlog;h=refs/heads/race-you-to-the-vcard | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
gabble debug output from test-vcard-race failing
my attempt at making a race-free test failing to crash gabble my attempt at making a race-free test |
||
This is actually a crasher: ERROR:vcard-manager.c:1010:manager_patch_vcard: assertion failed: (priv->edit_pipeline_item == NULL) Created attachment 26924 [details]
gabble debug output from test-vcard-race failing
Created attachment 26925 [details]
my attempt at making a race-free test failing to crash gabble
Created attachment 26926 [details]
my attempt at making a race-free test
Daf's attached branch 'race-you-to-the-vcard' should fix this. I endorse this service and/or product, and have merged it. It will be in 0.7.32. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Traceback (most recent call last): File "/home/wjt/src/telepathy/gabble/tests/twisted/gabbletest.py", line 381, in exec_test_deferred f(queue, bus, conn, stream) File "./vcard/test-vcard-race.py", line 55, in test expect_and_handle_set_vcard(q, stream, has_nickname_and_photo) File "/home/wjt/src/telepathy/gabble/tests/twisted/gabbletest.py", line 430, in expect_and_handle_set_vcard query_name='vCard', iq_type='set') File "/home/wjt/src/telepathy/gabble/tests/twisted/servicetest.py", line 114, in expect event = self.wait() File "/home/wjt/src/telepathy/gabble/tests/twisted/servicetest.py", line 187, in wait raise TimeoutError TimeoutError FAIL: vcard/test-vcard-race.py