| Summary: | Missing return value in xfree86/xf86config/xorgconfig.c | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Egbert Eich <eich> | ||||||
| Component: | App/xorgconfig | Assignee: | Roland Mainz <roland.mainz> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | high | CC: | alan.coopersmith, roland.mainz | ||||||
| Version: | 6.8.1 | ||||||||
| Hardware: | x86 (IA32) | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
Egbert Eich
2005-01-03 07:15:08 UTC
Created attachment 1622 [details] [review] [FIXED_X11R68x] Fix. Give the function a return value. 0 lets the loop terminate - that's what should happen if the user pressed 'q' which indicates the user wants to use the generic fallback driver. Fixed in HEAD. Comment on attachment 1622 [details] [review] [FIXED_X11R68x] Fix. Approved in the 2005-01-10 Xorg release wranglers phone call. Please don't commit yourself, I'll do that in a few mins... Comment on attachment 1622 [details] [review] [FIXED_X11R68x] Fix. Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.110; previous revision: 1.365.2.109 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/hw/xfree86/xf86config/xorgconfig.c,v <-- xorgconfig.c new revision: 1.6.2.1; previous revision: 1.6 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... Reopening bug for backout from X11R6.8.x stable branch as this patch broke the build there... Taking bug myself for backout... Created attachment 1813 [details] [review] [FIXED_X11R68x] Backout patch Comment on attachment 1813 [details] [review] [FIXED_X11R68x] Backout patch Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- xc/ChangeLog new revision: 1.365.2.148; previous revision: 1.365.2.147 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/hw/xfree86/xf86config/xorgconfig.c,v <-- xc/programs/Xserver/hw/xfree86/xf86config/xorgconfig.c new revision: 1.6.2.3; previous revision: 1.6.2.2 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... Marking bug as FIXED again. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.